Bug 71091

Summary: The test input-paste-undo.html needs update to work properly
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Tools / TestsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, enrica, mjs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Benjamin Poulain
Reported 2011-10-27 20:59:56 PDT
Focusing a node no longer select its content. The test input-paste-undo.html is written is such a way that a failure to paste the content does not make the test fail. You can remove the JavaScript, the test runs just fine.
Attachments
Patch (45.93 KB, patch)
2011-10-27 21:04 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch (100.51 KB, patch)
2011-10-27 22:52 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-10-27 21:04:47 PDT
Created attachment 112811 [details] Patch
Benjamin Poulain
Comment 2 2011-10-27 21:05:51 PDT
The pixel test results are from Lion, so they will likely require a rebase from the bots.
Alexey Proskuryakov
Comment 3 2011-10-27 21:19:46 PDT
Comment on attachment 112811 [details] Patch Can this be turned into a text-only test that measures element height?
Benjamin Poulain
Comment 4 2011-10-27 21:25:22 PDT
Comment on attachment 112811 [details] Patch (In reply to comment #3) > (From update of attachment 112811 [details]) > Can this be turned into a text-only test that measures element height? Sure, I can do that.
Benjamin Poulain
Comment 5 2011-10-27 22:52:16 PDT
Created attachment 112816 [details] Patch
David Kilzer (:ddkilzer)
Comment 6 2011-10-31 14:24:53 PDT
Comment on attachment 112816 [details] Patch r=me
WebKit Review Bot
Comment 7 2011-10-31 15:07:20 PDT
Comment on attachment 112816 [details] Patch Clearing flags on attachment: 112816 Committed r98886: <http://trac.webkit.org/changeset/98886>
WebKit Review Bot
Comment 8 2011-10-31 15:07:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.