Bug 71090

Summary:

Remove some unnecessary loads/stores in DFG JIT 32_64

Product:

WebKit

Reporter:

Yuqiang Xian <yuqiang.xian>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, fpizlo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch	fpizlo: review+, webkit.review.bot: commit-queue-
patch	none

Yuqiang Xian

Reported 2011-10-27 19:54:21 PDT

In fillSpeculateCell and OSR exit, some unnecessary loads/stores can be eliminated.

Attachments
the patch (6.11 KB, patch) 2011-10-27 19:58 PDT, Yuqiang Xian	fpizlo: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
patch (6.23 KB, patch) 2011-11-02 17:32 PDT, Yuqiang Xian	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yuqiang Xian

Comment 1 2011-10-27 19:58:20 PDT

Created attachment 112808 [details] the patch

Filip Pizlo

Comment 2 2011-11-02 17:23:56 PDT

Comment on attachment 112808 [details] the patch r=me

WebKit Review Bot

Comment 3 2011-11-02 17:26:14 PDT

Comment on attachment 112808 [details] the patch Rejecting attachment 112808 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ed at 1 with fuzz 3. patching file Source/JavaScriptCore/dfg/DFGJITCompiler32_64.cpp Hunk #1 succeeded at 237 (offset 24 lines). Hunk #2 succeeded at 373 (offset 24 lines). patching file Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp Hunk #1 FAILED at 295. 1 out of 1 hunk FAILED -- saving rejects to file Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Filip Pizlo', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10257430

Filip Pizlo

Comment 4 2011-11-02 17:27:28 PDT

Looks like this needs some merging, since I touched some of that same code. Yuqiang, can you merge this and land manually? R=me still applies.

Yuqiang Xian

Comment 5 2011-11-02 17:32:27 PDT

Created attachment 113407 [details] patch patch merging the latest changes.

Yuqiang Xian

Comment 6 2011-11-02 17:34:10 PDT

(In reply to comment #4) > Looks like this needs some merging, since I touched some of that same code. Yuqiang, can you merge this and land manually? R=me still applies. Thanks, the new patch has been uploaded. Can you please set cq+ if you're fine with it? I still don't have the commit access (though it's in process) by now.

WebKit Review Bot

Comment 7 2011-11-02 18:53:22 PDT

Comment on attachment 113407 [details] patch Clearing flags on attachment: 113407 Committed r99129: <http://trac.webkit.org/changeset/99129>

WebKit Review Bot

Comment 8 2011-11-02 18:53:27 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.