Bug 71059 – run-leaks does not work on Lion?

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Eric Seidel (no email)]

? checking for leaks in DumpRenderTree
run-leaks: Could not parse leak count reported by leaks tool.
 - no leaks found

Makes it very difficult to fully test my changes for bug 66227.

[David Kilzer (:ddkilzer)]

<rdar://problem/10428527>

[David Kilzer (:ddkilzer)]

I have a fix, and a way to unit-test parseLeaksOutput() without modifying the run-leaks script.

[David Kilzer (:ddkilzer)]

(In reply to comment #2)
> I have a fix, and a way to unit-test parseLeaksOutput() without modifying the run-leaks script.

http://stackoverflow.com/questions/232475/is-it-possible-use-or-require-a-perl-script-without-executing-its-statements

[David Kilzer (:ddkilzer)]

Created attachment 114997 [details]
Patch v1

[WebKit Review Bot]

Attachment 114997 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/run-leak..." exit_code: 1

Last 3072 characters of output:
/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:55:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:57:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:58:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:60:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:62:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:70:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:71:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:81:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:82:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:93:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:94:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:105:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:106:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:117:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:118:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:129:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:130:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:141:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:152:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:56:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:57:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:64:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:65:  Line contains tab character.  [whitespace/tab] [5]
Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:68:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 75 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Adam Roben (:aroben)]

Comment on attachment 114997 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=114997&action=review

> Tools/Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:36
> +eval "package RunLeaks; sub {" . read_file(File::Spec->catfile($FindBin::Bin, "../..", "run-leaks")) . "}";

It would be a little better to use "..", ".." instead of "../..". Ditto for your other test scripts.

[David Kilzer (:ddkilzer)]

(In reply to comment #5)
> Attachment 114997 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/run-leak..." exit_code: 1
> [...]
> Total errors found: 75 in 5 files
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Leaks output includes tabs, so I'll be adding the allow-tabs svn property when landing these tests.

[David Kilzer (:ddkilzer)]

Committed r100174: <http://trac.webkit.org/changeset/100174>

[Tony Chang]

The Windows and Linux (GTK/QT/Chromium) bots are complaining about File/Slurp.pm not being installed.  Can we write this without using Slurp or do we need to add this as a build dependency?

[David Kilzer (:ddkilzer)]

(In reply to comment #9)
> The Windows and Linux (GTK/QT/Chromium) bots are complaining about File/Slurp.pm not being installed.  Can we write this without using Slurp or do we need to add this as a build dependency?

It can probably be rewritten to not use File::Slurp.

[David Kilzer (:ddkilzer)]

(In reply to comment #10)
> (In reply to comment #9)
> > The Windows and Linux (GTK/QT/Chromium) bots are complaining about File/Slurp.pm not being installed.  Can we write this without using Slurp or do we need to add this as a build dependency?
> 
> It can probably be rewritten to not use File::Slurp.

http://stackoverflow.com/questions/953707/in-perl-how-can-i-read-an-entire-file-into-a-string
http://www.perlmonks.org/?node_id=1952

[David Kilzer (:ddkilzer)]

(In reply to comment #9)
> The Windows and Linux (GTK/QT/Chromium) bots are complaining about File/Slurp.pm not being installed.  Can we write this without using Slurp or do we need to add this as a build dependency?

Filed Bug 72356: Don't use File::Slurp for run-leaks unit tests

[Csaba Osztrogonác]

(In reply to comment #9)
> The Windows and Linux (GTK/QT/Chromium) bots are complaining about File/Slurp.pm not being installed.  Can we write this without using Slurp or do we need to add this as a build dependency?

I installed libfile-slurp-perl to the Qt bots, so it won't be problem anymore.