Bug 71037

Summary: Skip individual <track> LayoutTests
Product: WebKit Reporter: Anna Cavender <annacc>
Component: MediaAssignee: Anna Cavender <annacc>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Anna Cavender
Reported 2011-10-27 11:13:37 PDT
There are several tests in media/track that have been block-skipped. This patch will individually skip them so that we can start to add new tests to the media/track folder without skipping them. The existing tests don't run successfully because not enough functionality has been implemented. My general strategy going forward will be to include new, simpler tests that exercise only the functionality of each new patch as it is added. I will enable the tests that are skipped now as their required functionality becomes available in the future.
Attachments
Patch (18.98 KB, patch)
2011-10-27 11:19 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anna Cavender
Comment 1 2011-10-27 11:19:04 PDT
Created attachment 112713 [details] Patch
Sam Weinig
Comment 2 2011-10-27 13:27:44 PDT
Instead of skipping them, why don't we just check them in with failing results. That way, when you make them pass, we can see the progression?
Anna Cavender
Comment 3 2011-10-27 13:38:20 PDT
Not a bad idea. My only concern is that there are so many of them that future (incremental) patches will then contain lots of test updates. Is that preferable from a reviewers perspective? Either way is fine with me.
Adam Barth
Comment 4 2011-10-27 13:39:29 PDT
Comment on attachment 112713 [details] Patch @Sam: I believe because they time out rather than running to completion.
Adam Barth
Comment 5 2011-10-27 13:42:13 PDT
Incremental test updates are fine (good even) because they help us understand how patches change behavior. You list tests as timing out though, which causes a problem if they're slowing down the test suite.
Anna Cavender
Comment 6 2011-10-27 13:45:55 PDT
Potential solution: skip them for now because they time out. After I implement events, the tests won't time out anymore, but their results won't be perfect either. At that time, I'll unskip them and commit some failing results that can change with further progressions. Sound good?
Adam Barth
Comment 7 2011-10-27 13:49:04 PDT
Sounds good to me.
WebKit Review Bot
Comment 8 2011-10-27 14:48:51 PDT
Comment on attachment 112713 [details] Patch Clearing flags on attachment: 112713 Committed r98642: <http://trac.webkit.org/changeset/98642>
WebKit Review Bot
Comment 9 2011-10-27 14:48:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.