Bug 71034

Summary: Remove need for virtual JSObject::unwrappedObject
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: mhahnenberg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70960    
Attachments:
Description Flags
Patch
none
Patch
none
Patch ggaren: review+

Sam Weinig
Reported 2011-10-27 10:48:57 PDT
Remove need for virtual JSObject::unwrappedObject
Attachments
Patch (25.27 KB, patch)
2011-10-27 13:09 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (26.64 KB, patch)
2011-10-30 12:12 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (26.89 KB, patch)
2011-10-30 13:17 PDT, Sam Weinig 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-10-27 13:09:37 PDT
Created attachment 112738 [details] Patch
Sam Weinig
Comment 2 2011-10-30 12:12:03 PDT
Created attachment 112996 [details] Patch
Sam Weinig
Comment 3 2011-10-30 13:17:20 PDT
Created attachment 113000 [details] Patch
Filip Pizlo
Comment 4 2011-10-30 16:35:14 PDT
Comment on attachment 113000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113000&action=review > Source/JavaScriptCore/runtime/JSGlobalThis.cpp:33 > +ASSERT_CLASS_FITS_IN_CELL(JSGlobalThis); Is this needed, now that the GC can allocate things of any size?
Sam Weinig
Comment 5 2011-10-30 18:13:55 PDT
(In reply to comment #4) > (From update of attachment 113000 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=113000&action=review > > > Source/JavaScriptCore/runtime/JSGlobalThis.cpp:33 > > +ASSERT_CLASS_FITS_IN_CELL(JSGlobalThis); > > Is this needed, now that the GC can allocate things of any size? I don't know, I moved it from JSDOMWindowShell. If it isn't, should we remove all of them?
Geoffrey Garen
Comment 6 2011-10-30 18:25:37 PDT
Comment on attachment 113000 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113000&action=review r=me > Source/JavaScriptCore/runtime/JSGlobalThis.h:51 > + JSObject* unwrappedObject(); Please make this return JSGlobalObject*, since it's not the case that we're capable of wrapping any kind of JSObject. > Source/JavaScriptCore/runtime/JSGlobalThis.h:68 > + WriteBarrier<JSGlobalObject> m_globalVariables; Please change this name to match its accessor ("unwrappedObject()").
Sam Weinig
Comment 7 2011-10-31 16:44:03 PDT
Committed r98909: <http://trac.webkit.org/changeset/98909>
Note You need to log in before you can comment on or make changes to this bug.