Bug 71028 – Allow column progression to be independent of writing mode

• Component: Layout and Rendering
• Status: RESOLVED FIXED

<rdar://problem/10262205>

Created attachment 112701 [details]
Enable column progression along the block axis and add a CSS property to enable it

[WebKit Review Bot]

Attachment 112701 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/rendering/style/RenderStyle.h:762:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 112701 [details]
Enable column progression along the block axis and add a CSS property to enable it

View in context: https://bugs.webkit.org/attachment.cgi?id=112701&action=review

> Source/WebCore/ChangeLog:14
> +        Allow âcolumnsâ to be stacked along the block axis rather than the inline axis. This can facilitate

Character set unhappiness?

> Source/WebCore/rendering/RenderBlock.cpp:2391
> +        BoxSide boxSide = isHorizontalWritingMode() ?
> +            style()->isLeftToRightDirection() ? BSLeft : BSRight
> +            : style()->isLeftToRightDirection() ? BSTop : BSBottom;

I normally put the ? on the next line just over the : in a construction like this.

(In reply to comment #3)

Thanks for the review!

> (From update of attachment 112701 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=112701&action=review
> 
> > Source/WebCore/ChangeLog:14
> > +        Allow âcolumnsâ to be stacked along the block axis rather than the inline axis. This can facilitate
> 
> Character set unhappiness?

Yes, this is a bug in the component that shows “pretty” patches on bugs.webkit.org. If you view attachment 112701 [details] directly, the characters appear correctly.

> > Source/WebCore/rendering/RenderBlock.cpp:2391
> > +        BoxSide boxSide = isHorizontalWritingMode() ?
> > +            style()->isLeftToRightDirection() ? BSLeft : BSRight
> > +            : style()->isLeftToRightDirection() ? BSTop : BSBottom;
> 
> I normally put the ? on the next line just over the : in a construction like this.

I did it that way at first, but then I thought it might be too easy to think that the first line was the entire statement. I will change it back, though.

[Early Warning System Bot]

Comment on attachment 112701 [details]
Enable column progression along the block axis and add a CSS property to enable it

Attachment 112701 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10229563

Landed in <http://trac.webkit.org/r98608>.