Bug 71019

Summary:

[Chromium] css3/font-feature-settings-rendering.html has incorrect image result after r98542

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, johnnyg, koivisto, macpherson, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Linux

Attachments:

Description	Flags
patch	kling: review+

Description Yury Semikhatsky 2011-10-27 08:04:15 PDT

http://trac.webkit.org/changeset/98542/ broke css3/font-feature-settings-rendering.html on Chromium Linux:

http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/15508

Previous run was green:
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Linux/builds/15507

Comment 1 Yury Semikhatsky 2011-10-27 08:12:40 PDT

Added suppression for the failure: http://trac.webkit.org/changeset/98577

Comment 2 Yury Semikhatsky 2011-10-27 08:40:24 PDT

FWIW, tables/mozilla_expected_failures/bugs/bug14007-2.html results also changed after the change.

Comment 3 Antti Koivisto 2011-10-28 02:05:52 PDT

Created attachment 112834 [details]
patch

I think this should fix it. I can't test as this is a Chromium only feature.

Comment 4 Andreas Kling 2011-10-28 02:58:04 PDT

Comment on attachment 112834 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112834&action=review

Sure, r=me.

> LayoutTests/ChangeLog:3
> +

Excess newlinery.

Comment 5 Antti Koivisto 2011-10-28 04:52:51 PDT

http://trac.webkit.org/changeset/98716

Comment 6 Yury Semikhatsky 2011-10-28 06:12:32 PDT

(In reply to comment #3)
> Created an attachment (id=112834) [details]
> patch
> 
> I think this should fix it. I can't test as this is a Chromium only feature.

I confirm, the test now passes on Chromium. I removed the suppression http://trac.webkit.org/changeset/98723.

Thanks for fixing this!