Bug 71003

Summary: Web Inspector: remove ScriptStateProtectedPtr class.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, apavlov, barraclough, bweinstein, gustavo, japhet, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, xan.lopez, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch gyuyoung.kim: commit-queue-

Pavel Podivilov
Reported 2011-10-27 04:20:02 PDT
Web Inspector: remove ScriptStateProtectedPtr class. ScriptState is kept alive by ScriptArguments.m_arguments.
Attachments
Patch (5.59 KB, patch)
2011-10-27 04:21 PDT, Pavel Podivilov 		gyuyoung.kim: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pavel Podivilov
Comment 1 2011-10-27 04:21:26 PDT
Created attachment 112661 [details] Patch
Gyuyoung Kim
Comment 2 2011-10-27 04:27:19 PDT
Comment on attachment 112661 [details] Patch Attachment 112661 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10229423
Early Warning System Bot
Comment 3 2011-10-27 04:28:38 PDT
Comment on attachment 112661 [details] Patch Attachment 112661 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10231032
Gustavo Noronha (kov)
Comment 4 2011-10-27 04:35:18 PDT
Comment on attachment 112661 [details] Patch Attachment 112661 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10228423
Daniel Bates
Comment 5 2011-10-27 07:34:42 PDT
Comment on attachment 112661 [details] Patch Attachment 112661 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/10227531
Pavel Podivilov
Comment 6 2011-10-27 08:46:15 PDT
In JSC strong references to objects don't keep global object alive.
Gavin Barraclough
Comment 7 2011-10-27 11:19:49 PDT
(In reply to comment #6) > In JSC strong references to objects don't keep global object alive. Sure they do (now, at least - you're right that they didn't previously). All objects have a structure, the structure has a pointer to the globalObject, which will be marked during GC. Maybe I'm missing something, but this change does look valid to me.
Note You need to log in before you can comment on or make changes to this bug.