Bug 70990

Summary:

[EFL] Fix building with Glib support disabled

Product:

WebKit

Reporter:

Ivan Briano <ivan>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, lucas.de.marchi, mrobinson, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Ivan Briano

Reported 2011-10-26 21:07:45 PDT

[EFL] Fix building with Glib support disabled

Attachments
Patch (1.22 KB, patch) 2011-10-26 21:12 PDT, Ivan Briano	no flags	Details Formatted Diff Diff
Patch (1.32 KB, patch) 2011-10-27 08:10 PDT, Ivan Briano	no flags	Details Formatted Diff Diff
Patch (1.20 KB, patch) 2011-12-22 11:05 PST, Ivan Briano	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Ivan Briano

Comment 1 2011-10-26 21:12:02 PDT

Created attachment 112637 [details] Patch

WebKit Review Bot

Comment 2 2011-10-26 21:14:35 PDT

Attachment 112637 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/cairo/WidgetBackingStore.h:28: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ivan Briano

Comment 3 2011-10-27 08:10:33 PDT

Created attachment 112684 [details] Patch

Ivan Briano

Comment 4 2011-10-27 08:12:16 PDT

Comment on attachment 112684 [details] Patch I'm not sure this is the right way to fix this, but since platforms others than Gtk may want to use cairo, and the usage of cairo_surface_t is not under conditionals, it seems coherent to just have the right header included as well.

Martin Robinson

Comment 5 2011-10-27 08:39:01 PDT

Comment on attachment 112684 [details] Patch Why not add the typedefs here or create a similar typedefs file for yourself. We worked pretty hard to keep system headers out of WebCore/JSC headers.

Raphael Kubo da Costa (:rakuco)

Comment 6 2011-10-27 08:50:26 PDT

(In reply to comment #5) > (From update of attachment 112684 [details]) > Why not add the typedefs here or create a similar typedefs file for yourself. Just adding a typedef there should be fine IMHO. > We worked pretty hard to keep system headers out of WebCore/JSC headers. Hmm. Does it mean the same should be done to other headers (platform/graphics/CairoUtilities.h), for example?

Martin Robinson

Comment 7 2011-10-27 08:58:23 PDT

(In reply to comment #6) > Hmm. Does it mean the same should be done to other headers (platform/graphics/CairoUtilities.h), for example? Yes, if possible and within reason. :)

Eric Seidel (no email)

Comment 8 2011-12-19 11:49:06 PST

Comment on attachment 112684 [details] Patch Do we forward-declare these instead of including cairo.h?

Ivan Briano

Comment 9 2011-12-19 11:58:30 PST

Oh my, I had completely forgotten about this. I'll make a new patch this week.

Ivan Briano

Comment 10 2011-12-22 11:05:45 PST

Created attachment 120344 [details] Patch New patch. Leaving the declaration unconditional to match its usage below.

Martin Robinson

Comment 11 2011-12-22 12:36:44 PST

Comment on attachment 120344 [details] Patch I would have preferred this go within the PLATFORM(EFL) block, but this is fine.

Ivan Briano

Comment 12 2011-12-22 12:38:28 PST

Even when the type is used without any #ifdef later? I will keep that in mind if so. Thanks.

WebKit Review Bot

Comment 13 2011-12-23 02:06:11 PST

Comment on attachment 120344 [details] Patch Clearing flags on attachment: 120344 Committed r103614: <http://trac.webkit.org/changeset/103614>

WebKit Review Bot

Comment 14 2011-12-23 02:06:15 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.