Bug 70979

Summary: Overflow on flexitems doesn't work
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: Layout and RenderingAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
testcase
none
Patch none

Ojan Vafai
Reported 2011-10-26 16:27:19 PDT
Created attachment 112614 [details] testcase Specifically, it doesn't scroll.
Attachments
testcase (289 bytes, text/html)
2011-10-26 16:27 PDT, Ojan Vafai 		no flags
Details
Patch (4.49 KB, patch)
2012-01-11 17:07 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-01-11 14:29:00 PST
This seems to work for me now. I bet adding the layout in the stretch case fixed it. I'll add some tests for it.
Tony Chang
Comment 2 2012-01-11 17:07:38 PST
Created attachment 122133 [details] Patch
WebKit Review Bot
Comment 3 2012-01-11 19:55:52 PST
Comment on attachment 122133 [details] Patch Clearing flags on attachment: 122133 Committed r104785: <http://trac.webkit.org/changeset/104785>
WebKit Review Bot
Comment 4 2012-01-11 19:55:56 PST
All reviewed patches have been landed. Closing bug.
Tony Chang
Comment 5 2012-01-12 09:51:56 PST
Hmm, turns out that we get the wrong behavior when we're not using flex-item-align: stretch. I'll debug some more.
Tony Chang
Comment 6 2012-01-12 10:51:28 PST
(In reply to comment #5) > Hmm, turns out that we get the wrong behavior when we're not using flex-item-align: stretch. I'll debug some more. Nevermind, it's working properly. The cross direction was auto on the div that have 'overflow: auto' so there was no overflow in the cross direction (in the case of stretch, we would shrink to match the flexbox size and scrollbars would appear).
Note You need to log in before you can comment on or make changes to this bug.