Bug 70948

Summary: Remove Element::boundsInWindowSpace
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: NEW    
Severity: Normal CC: gustavo.noronha, gustavo, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch morrita: review-, gustavo.noronha: commit-queue-

Anders Carlsson
Reported 2011-10-26 11:33:10 PDT
Remove Element::boundsInWindowSpace
Attachments
Patch (3.28 KB, patch)
2011-10-26 11:33 PDT, Anders Carlsson 		morrita: review-
gustavo.noronha: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-10-26 11:33:36 PDT
Created attachment 112568 [details] Patch
Collabora GTK+ EWS bot
Comment 2 2011-10-26 15:40:27 PDT
Comment on attachment 112568 [details] Patch Attachment 112568 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10223135
Darin Adler
Comment 3 2011-10-26 16:31:12 PDT
Comment on attachment 112568 [details] Patch GTK failure: ../../Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: In member function ‘WebCore::IntRect WebKit::InjectedBundleNodeHandle::elementBounds() const’: ../../Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:112:49: error: ‘class WebCore::Element’ has no member named ‘boundsInWindowSpace’
Anders Carlsson
Comment 4 2011-10-26 16:46:27 PDT
(In reply to comment #3) > (From update of attachment 112568 [details]) > GTK failure: > > ../../Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: In member function ‘WebCore::IntRect WebKit::InjectedBundleNodeHandle::elementBounds() const’: > ../../Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:112:49: error: ‘class WebCore::Element’ has no member named ‘boundsInWindowSpace’ Yeah, we need to make elementBounds() return the bounds relative to the root view.
Daniel Bates
Comment 5 2011-10-26 19:17:56 PDT
Comment on attachment 112568 [details] Patch Attachment 112568 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/10214867
Hajime Morrita
Comment 6 2011-11-02 10:35:09 PDT
Comment on attachment 112568 [details] Patch r- for now to clear the queue.
Note You need to log in before you can comment on or make changes to this bug.