Bug 70948

Summary: Remove Element::boundsInWindowSpace
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: NEW ---    
Severity: Normal CC: gustavo.noronha, gustavo, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch morrita: review-, gustavo.noronha: commit-queue-

Description Anders Carlsson 2011-10-26 11:33:10 PDT 
Remove Element::boundsInWindowSpace
Comment 1 Anders Carlsson 2011-10-26 11:33:36 PDT 
Created attachment 112568 [details]
Patch
Comment 2 Collabora GTK+ EWS bot 2011-10-26 15:40:27 PDT 
Comment on attachment 112568 [details]
Patch

Attachment 112568 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/10223135
Comment 3 Darin Adler 2011-10-26 16:31:12 PDT 
Comment on attachment 112568 [details]
Patch

GTK failure:

../../Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: In member function ‘WebCore::IntRect WebKit::InjectedBundleNodeHandle::elementBounds() const’:
../../Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:112:49: error: ‘class WebCore::Element’ has no member named ‘boundsInWindowSpace’
Comment 4 Anders Carlsson 2011-10-26 16:46:27 PDT 
(In reply to comment #3)
> (From update of attachment 112568 [details])
> GTK failure:
> 
> ../../Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: In member function ‘WebCore::IntRect WebKit::InjectedBundleNodeHandle::elementBounds() const’:
> ../../Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:112:49: error: ‘class WebCore::Element’ has no member named ‘boundsInWindowSpace’

Yeah, we need to make elementBounds() return the bounds relative to the root view.
Comment 5 Daniel Bates 2011-10-26 19:17:56 PDT 
Comment on attachment 112568 [details]
Patch

Attachment 112568 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/10214867
Comment 6 Hajime Morrita 2011-11-02 10:35:09 PDT 
Comment on attachment 112568 [details]
Patch

r- for now to clear the queue.