Bug 70946

Summary: addMessage's last few arguments should be optional
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, gustavo, japhet, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2011-10-26 11:24:25 PDT
addMessage's last few arguments should be optional
Attachments
Patch (13.92 KB, patch)
2011-10-26 11:25 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (13.71 KB, patch)
2011-11-07 15:58 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-10-26 11:25:01 PDT
Created attachment 112566 [details] Patch
Early Warning System Bot
Comment 2 2011-10-26 11:38:43 PDT
Comment on attachment 112566 [details] Patch Attachment 112566 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10211638
Gyuyoung Kim
Comment 3 2011-10-26 11:39:57 PDT
Comment on attachment 112566 [details] Patch Attachment 112566 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10212635
WebKit Review Bot
Comment 4 2011-10-26 11:39:59 PDT
Comment on attachment 112566 [details] Patch Attachment 112566 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10211636
Adam Barth
Comment 5 2011-10-26 13:38:59 PDT
Comment on attachment 112566 [details] Patch I need to spend some quality time with the compiler.
Gustavo Noronha (kov)
Comment 6 2011-10-26 14:28:19 PDT
Comment on attachment 112566 [details] Patch Attachment 112566 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10212758
Daniel Bates
Comment 7 2011-10-26 16:25:29 PDT
Comment on attachment 112566 [details] Patch Attachment 112566 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/10220470
Adam Barth
Comment 8 2011-11-07 15:58:56 PST
Created attachment 113946 [details] Patch
WebKit Review Bot
Comment 9 2011-11-07 16:57:27 PST
Comment on attachment 113946 [details] Patch Clearing flags on attachment: 113946 Committed r99506: <http://trac.webkit.org/changeset/99506>
WebKit Review Bot
Comment 10 2011-11-07 16:57:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.