Bug 70916

Summary:

[EFL] protect ENABLE(DRAG_SUPPORT) methods in port

Product:

WebKit

Reporter:

Onne Gorter <o.gorter>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, leandro, lucas.de.marchi, rakuco

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
protects DRAG methods	none

Description Onne Gorter 2011-10-26 06:24:08 PDT

these methods may not be declared if options is disabled in build

Comment 1 Onne Gorter 2011-10-26 06:25:05 PDT

Created attachment 112497 [details]
protects DRAG methods

Comment 2 Gyuyoung Kim 2011-11-02 18:13:10 PDT

Comment on attachment 112497 [details]
protects DRAG methods

Please refer to WebKit Contribution Guide. (http://www.webkit.org/coding/contributing.html) You are missing ChangeLog.

Comment 3 Raphael Kubo da Costa (:rakuco) 2011-11-04 05:24:15 PDT

And *please* set at least the r? flag in your patch, otherwise the bots will not check it. I'll wait for them to check if the patch is OK and applies cleanly before reviewing.

Comment 4 Raphael Kubo da Costa (:rakuco) 2012-07-06 13:54:15 PDT

Fixed in <http://trac.webkit.org/changeset/115318>.