Bug 70893

Summary: [Qt] fast/canvas/canvas-composite-image.html and -canvas.html failing on Qt port
Product: WebKit Reporter: Gabor Rapcsanyi <rgabor>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: benwells, jamesr, ossy, tczene, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66920    
Attachments:
Description Flags
Added skipped test none

Gabor Rapcsanyi
Reported 2011-10-26 02:31:14 PDT
fast/canvas/canvas-composite-image.html failing on Qt port.
Attachments
Added skipped test (1.34 KB, patch)
2011-11-06 16:08 PST, Ben Wells 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gabor Rapcsanyi
Comment 1 2011-10-26 02:41:52 PDT
I skipped it until fix. (http://trac.webkit.org/changeset/98459) The diff is: --- /ramdisk/qt-linux-release/build/layout-test-results/fast/canvas/canvas-composite-image-expected.txt +++ /ramdisk/qt-linux-release/build/layout-test-results/fast/canvas/canvas-composite-image-actual.txt @@ -35,13 +35,27 @@ PASS Test: alpha on solid -PASS -Test: solid on alpha - -PASS -Test: alpha on alpha - -PASS +Error at (38, 30): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +Error at (34, 20): Actual color [32, 177, 128, 255]; Expected color [63, 255, 0, 128]; +Error at (48, 30): Actual color [32, 177, 128, 255]; Expected color [63, 255, 0, 128]; +Error at (65, 8): Actual color [122, 166, 154, 255]; Expected color [243, 233, 51, 128]; +Error at (77, 16): Actual color [95, 145, 223, 255]; Expected color [191, 191, 191, 128]; +Error at (77, 30): Actual color [95, 145, 223, 255]; Expected color [191, 191, 191, 128]; +Error at (74, 8): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +FAIL: 7 errors. +Test: solid on alpha + +PASS +Test: alpha on alpha + +Error at (38, 30): Actual color [0, 99, 255, 64]; Expected color [0, 0, 0, 0]; +Error at (34, 20): Actual color [32, 176, 128, 127]; Expected color [63, 255, 0, 64]; +Error at (48, 30): Actual color [32, 176, 128, 127]; Expected color [63, 255, 0, 64]; +Error at (65, 8): Actual color [120, 166, 154, 127]; Expected color [243, 231, 51, 64]; +Error at (77, 16): Actual color [94, 144, 222, 127]; Expected color [191, 191, 191, 64]; +Error at (77, 30): Actual color [94, 144, 222, 127]; Expected color [191, 191, 191, 64]; +Error at (74, 8): Actual color [0, 99, 255, 64]; Expected color [0, 0, 0, 0]; +FAIL: 7 errors. Mode: source-out Test: solid on solid @@ -49,13 +63,27 @@ PASS Test: alpha on solid -PASS -Test: solid on alpha - -PASS -Test: alpha on alpha - -PASS +Error at (38, 30): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +Error at (34, 20): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +Error at (48, 30): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +Error at (65, 8): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +Error at (77, 16): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +Error at (77, 30): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +Error at (74, 8): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +FAIL: 7 errors. +Test: solid on alpha + +PASS +Test: alpha on alpha + +Error at (38, 30): Actual color [0, 99, 255, 64]; Expected color [0, 0, 0, 0]; +Error at (34, 20): Actual color [31, 177, 127, 128]; Expected color [63, 255, 0, 64]; +Error at (48, 30): Actual color [31, 177, 127, 128]; Expected color [63, 255, 0, 64]; +Error at (65, 8): Actual color [121, 167, 153, 128]; Expected color [243, 231, 51, 64]; +Error at (77, 16): Actual color [95, 145, 223, 128]; Expected color [191, 191, 191, 64]; +Error at (77, 30): Actual color [95, 145, 223, 128]; Expected color [191, 191, 191, 64]; +Error at (74, 8): Actual color [0, 99, 255, 64]; Expected color [0, 0, 0, 0]; +FAIL: 7 errors. Mode: source-atop Test: solid on solid @@ -91,13 +119,27 @@ PASS Test: alpha on solid -PASS -Test: solid on alpha - -PASS -Test: alpha on alpha - -PASS +Error at (38, 30): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +Error at (34, 20): Actual color [0, 100, 255, 255]; Expected color [0, 99, 255, 128]; +Error at (48, 30): Actual color [0, 100, 255, 255]; Expected color [0, 99, 255, 128]; +Error at (65, 8): Actual color [0, 100, 255, 255]; Expected color [0, 99, 255, 128]; +Error at (77, 16): Actual color [0, 100, 255, 255]; Expected color [0, 99, 255, 128]; +Error at (77, 30): Actual color [0, 100, 255, 255]; Expected color [0, 99, 255, 128]; +Error at (74, 8): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +FAIL: 7 errors. +Test: solid on alpha + +PASS +Test: alpha on alpha + +Error at (38, 30): Actual color [0, 99, 255, 64]; Expected color [0, 0, 0, 0]; +Error at (34, 20): Actual color [0, 100, 255, 127]; Expected color [0, 101, 255, 63]; +Error at (48, 30): Actual color [0, 100, 255, 127]; Expected color [0, 101, 255, 63]; +Error at (65, 8): Actual color [0, 100, 255, 127]; Expected color [0, 101, 255, 63]; +Error at (77, 16): Actual color [0, 100, 255, 127]; Expected color [0, 101, 255, 63]; +Error at (77, 30): Actual color [0, 100, 255, 127]; Expected color [0, 101, 255, 63]; +Error at (74, 8): Actual color [0, 99, 255, 64]; Expected color [0, 0, 0, 0]; +FAIL: 7 errors. Mode: destination-out Test: solid on solid @@ -119,13 +161,27 @@ PASS Test: alpha on solid -PASS -Test: solid on alpha - -PASS -Test: alpha on alpha - -PASS +Error at (38, 30): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +Error at (34, 20): Actual color [0, 100, 255, 255]; Expected color [0, 99, 255, 128]; +Error at (48, 30): Actual color [0, 100, 255, 255]; Expected color [0, 99, 255, 128]; +Error at (65, 8): Actual color [0, 100, 255, 255]; Expected color [0, 99, 255, 128]; +Error at (77, 16): Actual color [0, 100, 255, 255]; Expected color [0, 99, 255, 128]; +Error at (77, 30): Actual color [0, 100, 255, 255]; Expected color [0, 99, 255, 128]; +Error at (74, 8): Actual color [0, 99, 255, 128]; Expected color [0, 0, 0, 0]; +FAIL: 7 errors. +Test: solid on alpha + +PASS +Test: alpha on alpha + +Error at (38, 30): Actual color [0, 99, 255, 64]; Expected color [0, 0, 0, 0]; +Error at (34, 20): Actual color [21, 152, 169, 191]; Expected color [31, 177, 127, 128]; +Error at (48, 30): Actual color [21, 152, 169, 191]; Expected color [31, 177, 127, 128]; +Error at (65, 8): Actual color [81, 144, 186, 191]; Expected color [121, 167, 153, 128]; +Error at (77, 16): Actual color [64, 130, 233, 191]; Expected color [95, 145, 223, 128]; +Error at (77, 30): Actual color [64, 130, 233, 191]; Expected color [95, 145, 223, 128]; +Error at (74, 8): Actual color [0, 99, 255, 64]; Expected color [0, 0, 0, 0]; +FAIL: 7 errors. Mode: lighter Test: solid on solid @@ -133,13 +189,23 @@ PASS Test: alpha on solid -PASS -Test: solid on alpha - -PASS -Test: alpha on alpha - -PASS +Error at (34, 20): Actual color [32, 177, 255, 255]; Expected color [32, 228, 255, 255]; +Error at (48, 30): Actual color [32, 177, 255, 255]; Expected color [32, 228, 255, 255]; +Error at (65, 8): Actual color [122, 177, 255, 255]; Expected color [122, 217, 255, 255]; +Error at (77, 16): Actual color [95, 177, 255, 255]; Expected color [96, 196, 255, 255]; +Error at (77, 30): Actual color [95, 177, 255, 255]; Expected color [96, 196, 255, 255]; +FAIL: 5 errors. +Test: solid on alpha + +PASS +Test: alpha on alpha + +Error at (34, 20): Actual color [42, 202, 169, 191]; Expected color [32, 178, 127, 255]; +Error at (48, 30): Actual color [42, 202, 169, 191]; Expected color [32, 178, 127, 255]; +Error at (65, 8): Actual color [162, 202, 204, 191]; Expected color [122, 167, 153, 255]; +Error at (77, 16): Actual color [126, 193, 255, 191]; Expected color [96, 146, 223, 255]; +Error at (77, 30): Actual color [126, 193, 255, 191]; Expected color [96, 146, 223, 255]; +FAIL: 5 errors. Mode: copy Test: solid on solid
Csaba Osztrogonác
Comment 2 2011-10-26 04:13:06 PDT
fast/canvas/canvas-composite-image.html is introduced in http://trac.webkit.org/changeset/98440
Csaba Osztrogonác
Comment 3 2011-10-26 04:13:43 PDT
and was added to the Qt skipped list: http://trac.webkit.org/changeset/98459
Ben Wells
Comment 4 2011-10-26 16:12:47 PDT
I'm not setup with the qt port to investigate what's wrong here. Looking at the results I'd say there is something not right for qt ports about the compositing change I made for image drawing. If that's the case there may also be problems with the fill changes made recently for compositing (bug 66036), and also with future fixes for other compositing bugs (e.g. bug 66762).
Ben Wells
Comment 5 2011-11-06 16:03:31 PST
fast/canvas/canvas-composite-canvas.html was just added and also fails. This test is almost identical to the canvas-composite-image.html test (testing drawImage(canvas) instead of drawImage(image) in an identifcal manner). I will add to skip file in same section. As I don't have cq access I'll push through this bug and then reopen.
Ben Wells
Comment 6 2011-11-06 16:08:13 PST
Created attachment 113810 [details] Added skipped test
Csaba Osztrogonác
Comment 7 2011-11-07 05:56:55 PST
*** Bug 71672 has been marked as a duplicate of this bug. ***
Csaba Osztrogonác
Comment 8 2011-11-07 05:57:54 PST
Comment on attachment 113810 [details] Added skipped test r=me. Let's see if CQ likes my name or not.
WebKit Review Bot
Comment 9 2011-11-07 06:01:17 PST
Comment on attachment 113810 [details] Added skipped test Rejecting attachment 113810 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 Last 500 characters of output: cripts/webkitpy/common/system/executive.py", line 420, in run_command close_fds=self._should_close_fds()) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/common/system/executive.py", line 476, in popen return subprocess.Popen(*args, **kwargs) File "/usr/lib/python2.6/subprocess.py", line 623, in __init__ errread, errwrite) File "/usr/lib/python2.6/subprocess.py", line 1141, in _execute_child raise child_exception TypeError: execv() arg 2 must contain only strings Full output: http://queues.webkit.org/results/10331680
Csaba Osztrogonác
Comment 10 2011-11-07 06:04:46 PST
Comment on attachment 113810 [details] Added skipped test Clearing flags on attachment: 113810 Committed r99413: <http://trac.webkit.org/changeset/99413>
Csaba Osztrogonác
Comment 11 2011-11-07 06:04:54 PST
All reviewed patches have been landed. Closing bug.
Ben Wells
Comment 12 2011-11-07 14:29:53 PST
This still needs to be fixed.
Jocelyn Turcotte
Comment 13 2014-02-03 03:19:08 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Note You need to log in before you can comment on or make changes to this bug.