Bug 70864

Summary: Embedded PDFs should be known to DocumentLoader
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: PDFAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch darin: review+

Alexey Proskuryakov
Reported 2011-10-25 17:22:12 PDT
Why? To better support Save As or saving to Web archive.
Attachments
proposed patch (20.62 KB, patch)
2011-10-25 17:32 PDT, Alexey Proskuryakov 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2011-10-25 17:32:08 PDT
Created attachment 112431 [details] proposed patch Perhaps it should ultimately be the job of PluginController implementation to save plug-in resources as necessary. But it's not clear to me how to structure that, and PDF is the only plug-in that currently needs this anyway.
Darin Adler
Comment 2 2011-10-26 10:21:43 PDT
Comment on attachment 112431 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=112431&action=review r=me but I’d really like you to explicitly state why this should be done > Source/WebKit2/ChangeLog:3 > + Embedded PDFs should be known to DocumentLoader This bug title doesn’t say why they should be known to DocumentLoader. And nothing in the change log says why either.
Alexey Proskuryakov
Comment 3 2011-10-26 10:48:44 PDT
Bug description has the rationale.
Alexey Proskuryakov
Comment 4 2011-10-26 11:12:27 PDT
Committed <http://trac.webkit.org/changeset/98503>.
Note You need to log in before you can comment on or make changes to this bug.