Bug 7080

Summary:

Provide some way to stop a JavaScript infinite loop

Product:

WebKit

Reporter:

Joost de Valk (AlthA) <joost>

Component:

JavaScriptCore

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Critical

CC:

active.23.13, bugzilla, darin, gavin.sharp, jay, krishnamurty.podipireddy

Priority:

Keywords:

InRadar

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Bug Depends on:

Bug Blocks:

6958, 3552, 6693

Attachments:

Description	Flags
Hang detection	none
Much better patch	mjs: review+
Add WebKit delegate	none
Address comments	none
Address Geoff's comments	ggaren: review+

Description Joost de Valk (AlthA) 2006-02-05 01:16:56 PST

At current, infinite javascript loops are really infinite, we need a way to detect and stop them.
This currently occurs in:

- bug 3552
- bug 6693
- bug 6958

This bug is here to track the development of a way to get out of this loop. All three bugs above have testcases, which could be used to test this behavior until their underlying bugs are fixed. All three of them have a root cause getting them into this infinite loop, so if these root causes are fixed they won't be useful for testing anymore.

Comment 1 Geoffrey Garen 2006-02-06 09:13:54 PST

In Radar as <rdar://problem/3895579>

Comment 2 Alexey Proskuryakov 2006-02-07 13:30:36 PST

*** Bug 6089 has been marked as a duplicate of this bug. ***

Comment 3 Krishna 2006-05-16 17:03:07 PDT

*** Bug 8949 has been marked as a duplicate of this bug. ***

Comment 4 Anders Carlsson 2006-06-15 16:28:38 PDT

Created attachment 8863 [details]
Hang detection

This implements the JSC part of a hang-detection implementation that works pretty much like the one in Mozilla.

Unfortunately, when turned on this causes a performance regression in ibench. The other approach I tried (using UNIX signals) proved to be complicated and error-prone and it too gave a performance regression (albeit a smaller one)

Comment 5 Darin Adler 2006-06-15 16:32:09 PDT

Off. It's going to be tricky to come up with a way to do this without slowing things down!

Comment 6 Geoffrey Garen 2006-06-15 19:43:53 PDT

Comment on attachment 8863 [details]
Hang detection

Clearing the review bit, since this was a perf. regression.

Comment 7 Anders Carlsson 2006-06-16 16:08:28 PDT

Created attachment 8872 [details]
Much better patch

Here's a new patch that doesn't cause any measurable slowdown at all (Less than 0.2% on ibench)

Comment 8 Maciej Stachowiak 2006-06-16 16:31:06 PDT

Comment on attachment 8872 [details]
Much better patch

r=me

ggaren likes it too

Comment 9 David Kilzer (:ddkilzer) 2006-06-16 18:20:46 PDT

Committed as r14893.

Comment 10 Anders Carlsson 2006-06-17 08:28:11 PDT

Created attachment 8886 [details]
Add WebKit delegate

Comment 11 Darin Adler 2006-06-17 17:16:44 PDT

Comment on attachment 8886 [details]
Add WebKit delegate

SCRIPT_TIMEOUT_TIME_MS should be a C++ const, not a macro.

The shouldInterruptScript functions could be const.

The WebDefaultUIDelegate is a pretty heavyweight way to make shouldInterruptJavaScript default to no. WebFrameBridge should just say return NO -- I don't think we need this method int the WebDefaultUIDelegate.

Comment 12 Anders Carlsson 2006-06-18 09:42:32 PDT

Created attachment 8902 [details]
Address comments

Comment 13 Anders Carlsson 2006-06-18 09:59:59 PDT

Created attachment 8903 [details]
Address Geoff's comments

I talked to Geoff on IRC and he had a couple of comments which this patch addresses.

Comment 14 Geoffrey Garen 2006-06-18 10:02:16 PDT

Comment on attachment 8903 [details]
Address Geoff's comments

r=me

and the crowd goes wild