Bug 7079

Summary: various event cleanup, including fixing of the load event for iframes
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: DOMAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
the fix (including test case) darin: review+

Maciej Stachowiak
Reported 2006-02-05 01:13:26 PST
I made a few improvements to event dispatch: - don't bother to nil-check the document, a node can never have a null document now - move temp event forgetting from dispatchEvent to dispatchGenericEvent - pass event down using RefPtr::release() to avoid ref thrashing - support default handlers even for non-bubbling events (only on target node) and skip calling default event handler explicitly in callers - dispatch a whole separate load event to a frame document's containing frame - don't let propagationStopped prevent this new event - remove bogus security check for iframe onload
Attachments
the fix (including test case) (13.24 KB, patch)
2006-02-05 01:17 PST, Maciej Stachowiak 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2006-02-05 01:17:49 PST
Created attachment 6264 [details] the fix (including test case)
Darin Adler
Comment 2 2006-02-05 01:28:54 PST
Comment on attachment 6264 [details] the fix (including test case) Looks good. Gave Maciej some comments on IRC. r=me
Darin Adler
Comment 3 2006-02-05 10:59:32 PST
Had to roll it out -- I think Maciej had a fix last night but the commit failed.
Adele Peterson
Comment 4 2006-02-06 20:15:09 PST
Maciej checked in a fixed version of this. Setting state to resolved/fixed.
Lucas Forschler
Comment 5 2019-02-06 09:02:46 PST
Mass moving XML DOM bugs to the "DOM" Component.
Note You need to log in before you can comment on or make changes to this bug.