flex-align:stretch + max-height needs to clamp to max-height and position appropriately

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Ojan Vafai]

See www-style discussion for the resolution of where it should be positioned: http://lists.w3.org/Archives/Public/www-style/2011Oct/0698.html

[Tony Chang]

Created attachment 115669 [details]
Patch

[Ojan Vafai]

Comment on attachment 115669 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115669&action=review

> Source/WebCore/rendering/RenderFlexibleBox.cpp:720
> +            Length logicalHeight = isHorizontalFlow() ? child->style()->height() : child->style()->width();

Nit: s/logicalHeight/crossAxisExtent

[Tony Chang]

Created attachment 115704 [details]
Patch

[Tony Chang]

(In reply to comment #2)
> (From update of attachment 115669 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=115669&action=review
> 
> > Source/WebCore/rendering/RenderFlexibleBox.cpp:720
> > +            Length logicalHeight = isHorizontalFlow() ? child->style()->height() : child->style()->width();
> 
> Nit: s/logicalHeight/crossAxisExtent

I switch to using logical height for all of this code since it only applies to row flexing.

[Ojan Vafai]

Comment on attachment 115704 [details]
Patch

LGTM

[Dave Hyatt]

Comment on attachment 115704 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=115704&action=review

r=me

> Source/WebCore/rendering/RenderBox.cpp:1805
> +    // In the case of columns that have a strech alignment, we go ahead and layout at the

Typo. strech should be stretch.

[Tony Chang]

Committed r101399: <http://trac.webkit.org/changeset/101399>