Bug 70772

Summary: flexbox scrollbars don't take flex-direction into account
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: Layout and RenderingAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch
none
Patch none

Ojan Vafai
Reported 2011-10-24 16:11:27 PDT
At a minimum, I'm pretty sure we don't take flex-flow into account when getting the height/width of the scrollbars.
Attachments
Patch (12.78 KB, patch)
2012-01-25 17:14 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch (12.79 KB, patch)
2012-01-26 11:07 PST, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2012-01-25 17:14:45 PST
Created attachment 124039 [details] Patch
Darin Adler
Comment 2 2012-01-26 10:57:08 PST
Comment on attachment 124039 [details] Patch It’s traditional to name bug reports after the bug. It’s OK to have a bug tracking adding tests, but not so great for clarity to name it that and then fix a bug in it.
Tony Chang
Comment 3 2012-01-26 11:07:11 PST
Created attachment 124151 [details] Patch
Tony Chang
Comment 4 2012-01-26 11:07:57 PST
Comment on attachment 124151 [details] Patch I'll wait a while to give Ojan a chance to take a look.
Ojan Vafai
Comment 5 2012-01-26 12:30:07 PST
(In reply to comment #4) > (From update of attachment 124151 [details]) > I'll wait a while to give Ojan a chance to take a look. LGTM
WebKit Review Bot
Comment 6 2012-01-27 10:12:22 PST
Comment on attachment 124151 [details] Patch Clearing flags on attachment: 124151 Committed r106129: <http://trac.webkit.org/changeset/106129>
WebKit Review Bot
Comment 7 2012-01-27 10:12:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.