Summary: | LayerRendererChromium::setVisible called needlessly without a visibility change | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Michal Mocny <mmocny> | ||||||
Component: | New Bugs | Assignee: | Michal Mocny <mmocny> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | jamesr, kbr, nduca, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Michal Mocny
2011-10-24 14:47:48 PDT
Created attachment 112253 [details]
Patch
This fixes the issues with setVisibilityCHROMIUM(true) being spammed after the recently plumbing changes (https://bugs.webkit.org/show_bug.cgi?id=70635). There are other options to prevent this, but talking with Nat it seems that there is no need for LayerRendererChromium::setVisible to be called unless visibility actually changed. Comment on attachment 112253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112253&action=review Seems ok modulo the comment above. > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:51 > + , m_visible(false) True or false here? I was expecting true personally. Do GL contexts start up "invisible"? Comment on attachment 112253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112253&action=review Nat's question is a good one. Small issue in the ChangeLog needs to be fixed as well. > Source/WebCore/ChangeLog:10 > + No new tests. (OOPS!) This second OOPS will have to be removed in order for the commit queue to process this patch. Created attachment 112339 [details]
Patch
Comment on attachment 112339 [details]
Patch
Looks fine. r=me
Comment on attachment 112339 [details] Patch Clearing flags on attachment: 112339 Committed r98392: <http://trac.webkit.org/changeset/98392> All reviewed patches have been landed. Closing bug. |