Bug 70766

Summary: LayerRendererChromium::setVisible called needlessly without a visibility change
Product: WebKit Reporter: Michal Mocny <mmocny>
Component: New BugsAssignee: Michal Mocny <mmocny>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, kbr, nduca, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Michal Mocny
Reported 2011-10-24 14:47:48 PDT
LayerRendererChromium::setVisible called needlessly without a visibility change
Attachments
Patch (2.43 KB, patch)
2011-10-24 14:50 PDT, Michal Mocny 		no flags
DetailsFormatted DiffDiff
Patch (2.44 KB, patch)
2011-10-25 08:27 PDT, Michal Mocny 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michal Mocny
Comment 1 2011-10-24 14:50:00 PDT
Created attachment 112253 [details] Patch
Michal Mocny
Comment 2 2011-10-24 14:54:58 PDT
This fixes the issues with setVisibilityCHROMIUM(true) being spammed after the recently plumbing changes (https://bugs.webkit.org/show_bug.cgi?id=70635). There are other options to prevent this, but talking with Nat it seems that there is no need for LayerRendererChromium::setVisible to be called unless visibility actually changed.
Nat Duca
Comment 3 2011-10-24 14:58:03 PDT
Comment on attachment 112253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112253&action=review Seems ok modulo the comment above. > Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:51 > + , m_visible(false) True or false here? I was expecting true personally. Do GL contexts start up "invisible"?
Kenneth Russell
Comment 4 2011-10-24 15:19:40 PDT
Comment on attachment 112253 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112253&action=review Nat's question is a good one. Small issue in the ChangeLog needs to be fixed as well. > Source/WebCore/ChangeLog:10 > + No new tests. (OOPS!) This second OOPS will have to be removed in order for the commit queue to process this patch.
Michal Mocny
Comment 5 2011-10-25 08:27:14 PDT
Created attachment 112339 [details] Patch
Kenneth Russell
Comment 6 2011-10-25 10:45:47 PDT
Comment on attachment 112339 [details] Patch Looks fine. r=me
WebKit Review Bot
Comment 7 2011-10-25 13:58:23 PDT
Comment on attachment 112339 [details] Patch Clearing flags on attachment: 112339 Committed r98392: <http://trac.webkit.org/changeset/98392>
WebKit Review Bot
Comment 8 2011-10-25 13:58:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.