Bug 7071

Summary: REGRESSION: Jumping to an anchor identifier makes page scroll horizontally
Product: WebKit Reporter: David Kilzer (:ddkilzer) <ddkilzer>
Component: DOMAssignee: Darin Adler <darin>
Status: VERIFIED FIXED    
Severity: Normal CC: adele, darin, vicki
Priority: P1 Keywords: HasReduction, Regression
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Test case
none
patch to fix the problem, including change log and test adele: review+

David Kilzer (:ddkilzer)
Reported 2006-02-04 13:46:02 PST
Clicking on a '#name' link where the <a name="name"></a> tag is offset from the left side of the page causes the page to scroll to the right (assuming content on the page is wider than the visible area). This is a regression from Safari 2.0.3 (417.8) in 10.4.4. Test with ToT on revision r12557.
Attachments
Test case (540 bytes, text/html)
2006-02-04 13:46 PST, David Kilzer (:ddkilzer) 		no flags
Details
patch to fix the problem, including change log and test (12.22 KB, patch)
2006-02-04 23:52 PST, Darin Adler 		adele: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2006-02-04 13:46:38 PST
Created attachment 6252 [details] Test case
David Kilzer (:ddkilzer)
Comment 2 2006-02-04 13:53:20 PST
Neither Firefox 1.5.0.1 nor MSIE 6 jump to the right using the test case (Attachment 6252 [details]).
David Kilzer (:ddkilzer)
Comment 3 2006-02-04 15:42:29 PST
Doing a binary search of nightly builds, the regression occurred here: Broken: WebKit-SVN-r12476.dmg Mon Jan 30 10:04:50 GMT 2006 Not broken: WebKit-SVN-r12467.dmg Mon Jan 30 4:45:53 GMT 2006
Darin Adler
Comment 4 2006-02-04 22:42:05 PST
My first guess would be that I broke this when doing my cleanup of Int/Float-Size/Point/Rect classes.
Darin Adler
Comment 5 2006-02-04 22:55:04 PST
Yes, I caused this problem by changing the definition of what the intersection function does for empty rectangles. Empty intersections now return a completely empty rectangle, but getRectToExpose depends on the old behavior where the X and Y intersections were separate.
Darin Adler
Comment 6 2006-02-04 23:52:52 PST
Created attachment 6259 [details] patch to fix the problem, including change log and test
Adele Peterson
Comment 7 2006-02-06 11:32:26 PST
Comment on attachment 6259 [details] patch to fix the problem, including change log and test looks good. r=me
David Kilzer (:ddkilzer)
Comment 8 2006-02-06 22:31:26 PST
Verified fixed!
Note You need to log in before you can comment on or make changes to this bug.