Bug 7068
| Summary: | REGRESSION: crashes in CSSStyleSelector::applyDeclarations running the layout tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | mitz |
| Component: | CSS | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Blocker | CC: | ap, kimmo.t.kinnunen |
| Priority: | P1 | Keywords: | Regression |
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
mitz
I'm getting random crashes when running the layout tests with r12554, but not with r12540. The crashes are in CSSStyleSelector::applyDeclarations apparently because it is called with an endIndex >= 0 while m_matchedDecls.size() is 0.
run-webkit-tests svg
alone usually crashes before it ends.
I suspect the fix for bug 4127.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
Confirmed with r12556 (debug build).
mitz
I tested with r12548 and r12549 and it looks like it really started with the fix for bug 4127.
Darin Adler
Can't safely check in other changes if layout tests are crashing, so upping severity to "blocker".
Darin Adler
I think we're going to have to roll out the build 4127 changes, otherwise we won't be able to test other changes before checking them in.
Darin Adler
Bug 4127, I mean.
Maciej Stachowiak
I rolled out the change for bug 4127