Bug 70673

Summary: Separated string lifetime bits from character buffer state bits
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, barraclough, japhet, msaboff, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Geoffrey Garen
Reported 2011-10-21 23:50:40 PDT
Separated string lifetime bits from character bufer state bits
Attachments
Patch (30.34 KB, patch)
2011-10-22 00:28 PDT, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
Patch (31.65 KB, patch)
2011-10-22 11:14 PDT, Geoffrey Garen 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-10-22 00:28:07 PDT
Created attachment 112081 [details] Patch
WebKit Review Bot
Comment 2 2011-10-22 00:31:01 PDT
Attachment 112081 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/JavaScriptCore/wtf/text/StringImpl.h:275: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Daniel Bates
Comment 3 2011-10-22 02:12:23 PDT
Comment on attachment 112081 [details] Patch Attachment 112081 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/10202168
Geoffrey Garen
Comment 4 2011-10-22 10:42:11 PDT
@dbates Look closer at the mac-ews results: "Unable to build without patch [results]".
Geoffrey Garen
Comment 5 2011-10-22 11:14:42 PDT
Created attachment 112091 [details] Patch
WebKit Review Bot
Comment 6 2011-10-22 11:16:26 PDT
Attachment 112091 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/JavaScriptCore/wtf/text/StringImpl.h:275: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 7 2011-10-23 00:20:37 PDT
Committed r98199: <http://trac.webkit.org/changeset/98199>
Note You need to log in before you can comment on or make changes to this bug.