Bug 70661

Summary: Remove unnecessary and confusing RetainPtr from ImageBufferCG::copyImage
Product: WebKit Reporter: Matthew Delaney <mdelaney7>
Component: New BugsAssignee: Matthew Delaney <mdelaney7>
Status: NEW    
Severity: Normal CC: ahmad.saleem792, ap, bfulgham, darin, eric.carlson, jer.noble, sam, simon.fraser, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch simon.fraser: review-

Matthew Delaney
Reported 2011-10-21 17:13:12 PDT
Remove unnecessary and confusing RetainPtr from ImaegBufferCG::copyImage
Attachments
Patch (1.56 KB, patch)
2011-10-21 17:16 PDT, Matthew Delaney 		simon.fraser: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matthew Delaney
Comment 1 2011-10-21 17:16:19 PDT
Created attachment 112046 [details] Patch
Simon Fraser (smfr)
Comment 2 2011-10-21 17:28:25 PDT
Comment on attachment 112046 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112046&action=review It looks like MediaPlayerPrivateAVFoundationObjC::createImageForTimeInRect() may have a similar leak. > Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:209 > + // BitmapImage takes ownnership of the image I think this also needs to be cleaned up. BitmapImage should not take ownership, just retain itself.
Ahmad Saleem
Comment 3 2022-09-10 15:56:32 PDT
Simon - is this needed anymore? Thanks!
Note You need to log in before you can comment on or make changes to this bug.