Bug 70657

Summary: watchlist for WebIDL shouldn't trigger on Internals.idl
Product: WebKit Reporter: Adam Barth <abarth>
Component: Tools / TestsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: levin, ojan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-10-21 15:54:54 PDT
watchlist for WebIDL shouldn't trigger on Internals.idl
Attachments
Patch (1.23 KB, patch)
2011-11-04 13:20 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-11-04 13:20:13 PDT
Created attachment 113702 [details] Patch
David Levin
Comment 2 2011-11-04 13:30:11 PDT
Comment on attachment 113702 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113702&action=review > Tools/Scripts/webkitpy/common/config/watchlist:35 > + "filename": r"Source/WebCore/(?!inspector)(?!testing).*\.idl" Why testing when the bug is about Internals.idl ?
David Levin
Comment 3 2011-11-04 13:30:58 PDT
Comment on attachment 113702 [details] Patch oh I get it. This bug is really about not trigger for test file idl changes. ok.
WebKit Review Bot
Comment 4 2011-11-04 13:49:08 PDT
Comment on attachment 113702 [details] Patch Clearing flags on attachment: 113702 Committed r99314: <http://trac.webkit.org/changeset/99314>
WebKit Review Bot
Comment 5 2011-11-04 13:49:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.