Bug 70651

Summary: [Qt] Remote debugging needs QWebInspector to work
Product: WebKit Reporter: Luiz Agostini <luiz>
Component: New BugsAssignee: Luiz Agostini <luiz>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
kenneth: review+
patch none

Luiz Agostini
Reported 2011-10-21 14:32:33 PDT
Remote debugger causes a crash if the page does not have a QWebInspector associated to it. QWebInspector is a QWidget object that should not be needed by the remote inspector.
Attachments
patch (9.72 KB, patch)
2011-10-21 14:46 PDT, Luiz Agostini 		kenneth: review+
DetailsFormatted DiffDiff
patch (9.71 KB, patch)
2011-10-21 15:17 PDT, Luiz Agostini 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luiz Agostini
Comment 1 2011-10-21 14:46:44 PDT
Created attachment 112024 [details] patch
Kenneth Rohde Christiansen
Comment 2 2011-10-21 14:52:46 PDT
Comment on attachment 112024 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=112024&action=review > Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:287 > + WTF::CString qwe = message.utf8(); Can you find a better name than qwe.... I have no idea what that stands for
Luiz Agostini
Comment 3 2011-10-21 14:55:16 PDT
(In reply to comment #2) > (From update of attachment 112024 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=112024&action=review > > > Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp:287 > > + WTF::CString qwe = message.utf8(); > > Can you find a better name than qwe.... I have no idea what that stands for absolutely! :) Sorry for that.
Luiz Agostini
Comment 4 2011-10-21 15:17:28 PDT
Created attachment 112031 [details] patch
WebKit Review Bot
Comment 5 2011-10-21 15:32:42 PDT
Comment on attachment 112031 [details] patch Clearing flags on attachment: 112031 Committed r98162: <http://trac.webkit.org/changeset/98162>
WebKit Review Bot
Comment 6 2011-10-21 15:32:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.