Bug 70636

Summary: Event.h has too many virtual isMumbleEvent() functions
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, japhet, ojan, sam, tkent, webkit.review.bot, yosin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch dglazkov: review+

Adam Barth
Reported 2011-10-21 13:11:23 PDT
Event.h has too many virtual isMumbleEvent() functions
Attachments
Patch (33.74 KB, patch)
2011-10-21 13:12 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (30.15 KB, patch)
2011-10-21 13:38 PDT, Adam Barth 		dglazkov: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-10-21 13:12:32 PDT
Created attachment 112006 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-10-21 13:16:50 PDT
Comment on attachment 112006 [details] Patch Whoa, this is freakishly cool.
Adam Barth
Comment 3 2011-10-21 13:17:25 PDT
It doesn't quite compile yet, but soon.
Adam Barth
Comment 4 2011-10-21 13:38:51 PDT
Created attachment 112012 [details] Patch
Eric Seidel (no email)
Comment 5 2011-10-21 13:41:44 PDT
Comment on attachment 112006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112006&action=review > Source/WebCore/bindings/js/JSErrorHandler.cpp:56 > + if (event->interfaceName() != eventNames().interfaceForErrorEvent) I think you want a .hasInterfaceName() instead. > Source/WebCore/bindings/objc/DOMEvents.mm:70 > + if (desiredInterface == eventNames().interfaceForMessageEvent) soooooo verbose.
Adam Barth
Comment 6 2011-10-21 13:42:29 PDT
(In reply to comment #5) > (From update of attachment 112006 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=112006&action=review > > > Source/WebCore/bindings/objc/DOMEvents.mm:70 > > + if (desiredInterface == eventNames().interfaceForMessageEvent) > > soooooo verbose. Yes. The actually-maintained bindings have this code autogenerated.
Adam Barth
Comment 7 2011-10-21 13:45:25 PDT
> I think you want a .hasInterfaceName() instead. I'm happy to add that, but I'd like to do that in a follow up patch.
Adam Barth
Comment 8 2011-10-21 14:06:13 PDT
Committed r98146: <http://trac.webkit.org/changeset/98146>
Note You need to log in before you can comment on or make changes to this bug.