Bug 70598

Summary:

Web Inspector: Unchecking a style rule should comment it out

Product:

WebKit

Reporter:

Nikita Vasilyev <me>

Component:

Web Inspector

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, graouts, joepeck, keishi, loislo, pfeldman, pmuellr, rik, robert.colburn+bugzilla, timothy, vivekgalatage, webkit-bug-importer, yurys

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Comment out unchecked CSS rule	none

Nikita Vasilyev

Reported 2011-10-21 04:29:02 PDT

Created attachment 111939 [details] Comment out unchecked CSS rule See attached image. Currently, disabling style rule does not modify CSS content. Commenting it out would be nice.

Attachments
Comment out unchecked CSS rule (76.50 KB, image/png) 2011-10-21 04:29 PDT, Nikita Vasilyev	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Vivek Galatage

Comment 1 2012-04-02 05:12:22 PDT

Should this toggling of CSS property result in creating new revision of the stylesheet in the resource view?

Alexander Pavlov (apavlov)

Comment 2 2012-04-02 10:11:35 PDT

Vivek: no it shouldn't. If a designer were to play around with disabling really many properties during a session, they could get hundreds of stylesheet revisions per the Inspector session, thereby turning the revision tracking completely unusable (and potentially getting a severe memory impact (or even OOM crashes) with very big stylesheets.)

Nikita Vasilyev

Comment 3 2012-04-02 12:22:03 PDT

The idea is to save a stylesheet including commented out rules. Is it possible without creating a revision for every disabled style rule?

Rob Colburn

Comment 4 2012-05-10 12:29:24 PDT

@Alexander, @Vivek Performing other small/incremental changes, like adjusting a color property 100 times, also creates a version for each change. So, the change is not entirely inconceivable because we already create a ton of versions. Right now, it's just inconsistent. Theoretically, I think we could potentially solve the problem a different way. It would deserve it's own ticket and discussion though. Instead of creating a version of the style-sheet for each change performed in the Elements panel, what if we made those changes to a "TRUNK" version, that we save that version upon viewing the resource in the Resource panel.

Timothy Hatcher

Comment 5 2013-06-17 06:53:12 PDT

We agree. The new WebKit Web Inspector does this.

Radar WebKit Bug Importer

Comment 6 2013-06-17 06:53:29 PDT

<rdar://problem/14173879>

Note You need to log in before you can comment on or make changes to this bug.