Summary: | TinyMCE: Select All + delete sends you Back intsead of deleting | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Justin Garcia <justin.garcia> | ||||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | Keywords: | EasyFix | ||||||
Priority: | P2 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 6627 | ||||||||
Attachments: |
|
Description
Justin Garcia
2006-02-03 16:34:40 PST
We select iframes and other special elements when their contents are fully selected, to make them easier to delete when they occur in an editable region. I think that's what's happening here. Since the special element itself isn't editable, the delete key is responded to with a Back instead of a delete operation. Created attachment 6799 [details]
patch
In selectFrameElementInParentIfFullySelected, we should only select the frame in its parent if the frame is in an editable region.
Also, WebCore wasn't treating mouse events that the eventSender was sending as distinct events, since they all had the same eventNumber (0). This was sending us into different code paths than we get into when a user does mouse clicks. So, I added an eventNumber to the eventSender and increment it every time DRT creates an event.
Created attachment 6801 [details]
patch
small tweak
|