Bug 70588

Summary: Bencher script doesn't measure GC times accurately
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2011-10-21 01:32:18 PDT
The bencher script runs benchmarks using the SunSpider harness style, where gc() is invoked between samples. This means that GC times tend to not be measured. But particularly SunSpider and V8 have significant GC pressure when run repeatedly. The bencher script should retain its default mode (since it's great for pinpointing performance changes in the mutator) but have options to also measure GC times.
Attachments
the patch (10.92 KB, patch)
2011-10-21 01:41 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-10-21 01:41:45 PDT
Created attachment 111921 [details] the patch
Geoffrey Garen
Comment 2 2011-10-21 12:06:52 PDT
Comment on attachment 111921 [details] the patch rs=me
Filip Pizlo
Comment 3 2011-10-21 16:20:01 PDT
Landed in http://trac.webkit.org/changeset/98167
Note You need to log in before you can comment on or make changes to this bug.