Bug 70563
| Summary: | RenderMenuList.cpp does not build when NO_LISTBOX_RENDERING is enabled | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jay Civelli <jcivelli> |
| Component: | WebCore Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | darin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Jay Civelli
A recent change to html/HTMLSelectElement.h removed the listBoxSelectItem method that is used by RenderMenuList.cpp.
As a result that file won't compile when NO_LISTBOX_RENDERING is enabled.
This change happened in https://bugs.webkit.org/show_bug.cgi?id=70139
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Darin Adler
What is NO_LISTBOX_RENDERING? What platform uses that?
Jay Civelli
The Android browser uses NO_LISTBOX_RENDERING.
The select popup is rendered with an Android widget.
Darin Adler
We should get Android compiling again. But lets not have an Android-only function. Lets figure out how not to have this extra function in HTMLSelectElement eventually if not in the short term.