Bug 70554

Summary: [Chromium] Fix opaque flag default and for ImageLayerChromium
Product: WebKit Reporter: Dana Jansens <danakj>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: backer, danakj, jamesr, piman, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Fixed changelog none

Dana Jansens
Reported 2011-10-20 15:36:39 PDT
[Chromium] Fix opaque flag default and for ImageLayerChromium
Attachments
Patch (2.33 KB, patch)
2011-10-20 15:38 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Fixed changelog (2.33 KB, patch)
2011-10-20 16:46 PDT, Dana Jansens 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dana Jansens
Comment 1 2011-10-20 15:38:28 PDT
Created attachment 111858 [details] Patch
Dana Jansens
Comment 2 2011-10-20 15:39:58 PDT
I thought I'd fix the opaque flag in a separate CL, especially since the ImageLayerChromium seems like it can be fixed along with it. Is this right?
Antoine Labour
Comment 3 2011-10-20 15:41:57 PDT
This LGTM
James Robinson
Comment 4 2011-10-20 16:03:25 PDT
Comment on attachment 111858 [details] Patch R=me Can you construct some layout tests with opaque and non-opaque images that get composited (or verify that we have such tests already) as part of the patch that disables blending for opaque layers? I want to make sure we have testing there.
Dana Jansens
Comment 5 2011-10-20 16:46:51 PDT
Created attachment 111872 [details] Fixed changelog
WebKit Review Bot
Comment 6 2011-10-20 19:23:13 PDT
Comment on attachment 111872 [details] Fixed changelog Clearing flags on attachment: 111872 Committed r98055: <http://trac.webkit.org/changeset/98055>
WebKit Review Bot
Comment 7 2011-10-20 19:23:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.