Summary: | [Qt][WK2] Remove QtWidgets dependency in MiniBrowser | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zeno Albisser <zeno> | ||||||||
Component: | WebKit Qt | Assignee: | Zeno Albisser <zeno> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | hausmann | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 70525 | ||||||||||
Bug Blocks: | 70315, 70537 | ||||||||||
Attachments: |
|
Description
Zeno Albisser
2011-10-20 11:30:46 PDT
Created attachment 111821 [details]
patch for review.
Created attachment 111832 [details]
patch for review.
fixed ChangeLog
Created attachment 112322 [details]
patch for review. - save touch mocking.
Comment on attachment 112322 [details] patch for review. - save touch mocking. View in context: https://bugs.webkit.org/attachment.cgi?id=112322&action=review > Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:-165 > - return true; if we return true here, then mouse events will not be delivered anymore. Comment on attachment 112322 [details] patch for review. - save touch mocking. View in context: https://bugs.webkit.org/attachment.cgi?id=112322&action=review r=me > Tools/ChangeLog:9 > + Change BrowserWindow to derive from QSGView instead of > + QMainWindow. QSGView is used as a top level window that We're going to have the land this before Friday, otherwise the patch will need work to adapt to the QSG* -> QQuick* renaming. > Tools/MiniBrowser/qt/main.cpp:33 > +#include <QDir> This seems unnecessary? Comment on attachment 112322 [details] patch for review. - save touch mocking. View in context: https://bugs.webkit.org/attachment.cgi?id=112322&action=review >> Tools/MiniBrowser/qt/main.cpp:33 >> +#include <QDir> > > This seems unnecessary? No, this one is indeed necessary. It was transitive fulfilled by including MiniBrowserApplication.h, which included <QFileDialog>. (And that was removed by this patch) Committed r98448: <http://trac.webkit.org/changeset/98448> |