Bug 70529

Summary: [Qt][WK2] Remove QtWidgets dependency in MiniBrowser
Product: WebKit Reporter: Zeno Albisser <zeno>
Component: WebKit QtAssignee: Zeno Albisser <zeno>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 70525    
Bug Blocks: 70315, 70537    
Attachments:
Description Flags
patch for review.
none
patch for review.
none
patch for review. - save touch mocking. hausmann: review+

Zeno Albisser
Reported 2011-10-20 11:30:46 PDT
This is a requirement for creating an entirely QML based solution.
Attachments
patch for review. (28.54 KB, patch)
2011-10-20 12:16 PDT, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
patch for review. (28.43 KB, patch)
2011-10-20 13:13 PDT, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
patch for review. - save touch mocking. (26.60 KB, patch)
2011-10-25 04:59 PDT, Zeno Albisser 		hausmann: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Zeno Albisser
Comment 1 2011-10-20 12:16:53 PDT
Created attachment 111821 [details] patch for review.
Zeno Albisser
Comment 2 2011-10-20 13:13:48 PDT
Created attachment 111832 [details] patch for review. fixed ChangeLog
Zeno Albisser
Comment 3 2011-10-25 04:59:04 PDT
Created attachment 112322 [details] patch for review. - save touch mocking.
Zeno Albisser
Comment 4 2011-10-25 05:22:13 PDT
Comment on attachment 112322 [details] patch for review. - save touch mocking. View in context: https://bugs.webkit.org/attachment.cgi?id=112322&action=review > Tools/MiniBrowser/qt/MiniBrowserApplication.cpp:-165 > - return true; if we return true here, then mouse events will not be delivered anymore.
Simon Hausmann
Comment 5 2011-10-25 05:26:27 PDT
Comment on attachment 112322 [details] patch for review. - save touch mocking. View in context: https://bugs.webkit.org/attachment.cgi?id=112322&action=review r=me > Tools/ChangeLog:9 > + Change BrowserWindow to derive from QSGView instead of > + QMainWindow. QSGView is used as a top level window that We're going to have the land this before Friday, otherwise the patch will need work to adapt to the QSG* -> QQuick* renaming. > Tools/MiniBrowser/qt/main.cpp:33 > +#include <QDir> This seems unnecessary?
Zeno Albisser
Comment 6 2011-10-25 05:34:21 PDT
Comment on attachment 112322 [details] patch for review. - save touch mocking. View in context: https://bugs.webkit.org/attachment.cgi?id=112322&action=review >> Tools/MiniBrowser/qt/main.cpp:33 >> +#include <QDir> > > This seems unnecessary? No, this one is indeed necessary. It was transitive fulfilled by including MiniBrowserApplication.h, which included <QFileDialog>. (And that was removed by this patch)
Simon Hausmann
Comment 7 2011-10-26 01:29:37 PDT
Committed r98448: <http://trac.webkit.org/changeset/98448>
Note You need to log in before you can comment on or make changes to this bug.