Bug 70508

Summary:

SKIP most layout tests on Leopard-Skia, rather than running and ignoring results

Product:

WebKit

Reporter:

epoger

Component:

Tools / Tests

Assignee:

epoger

Status:

RESOLVED INVALID

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	abarth: review+, caryclark: commit-queue-

Description epoger 2011-10-20 09:23:57 PDT

It seems silly to bother running these tests, just to ignore their results...

I originally thought it would be useful to track their results on the production bots, but I just remove the test_expectations lines and run layout_tests locally anyway.

Comment 1 epoger 2011-10-20 10:22:08 PDT

Created attachment 111803 [details]
Patch

Comment 2 epoger 2011-10-20 10:29:23 PDT

Created attachment 111804 [details]
Patch

Comment 3 epoger 2011-10-20 11:07:31 PDT

I have run layout_tests locally (both CPU and GPU, against both Skia and CG) to confirm that this patch has no ill effect.

Comment 4 Cary Clark 2011-10-20 12:07:43 PDT

Comment on attachment 111804 [details]
Patch

Elliot and I discussed this and could find little benefit to this change, since shortly, Leopard tests will be turned on for real.

Comment 5 epoger 2011-10-20 12:46:07 PDT

Cary's right... unless chromium-mac-leopard bot cycle time is a big problem right now, this is a solution in search of a problem.