Bug 70502

Summary: REGRESSION(r97964): They broke all geolocation tests in debug mode (Requested by Ossy on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kenneth, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70328    
Attachments:
Description Flags
ROLLOUT of r97964 none

Description WebKit Review Bot 2011-10-20 08:11:04 PDT
http://trac.webkit.org/changeset/97964 broke the build:
They broke all geolocation tests in debug mode (Requested by Ossy on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2011-10-20 08:11:39 PDT
Created attachment 111774 [details]
ROLLOUT of r97964

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Csaba Osztrogonác 2011-10-20 08:13:59 PDT
ASSERTION FAILED: m_isActive
../../../Source/WebCore/platform/mock/GeolocationClientMock.cpp(146) : virtual void WebCore::GeolocationClientMock::stopUpdating()
Comment 3 WebKit Review Bot 2011-10-20 08:18:04 PDT
Comment on attachment 111774 [details]
ROLLOUT of r97964

Clearing flags on attachment: 111774

Committed r97981: <http://trac.webkit.org/changeset/97981>
Comment 4 WebKit Review Bot 2011-10-20 08:18:08 PDT
All reviewed patches have been landed.  Closing bug.