Bug 70478

Summary:

[EFL] Unregister 'viewport,changed' signal in EWebLauncher

Product:

WebKit

Reporter:

Gyuyoung Kim <gyuyoung.kim>

Component:

WebKit EFL

Assignee:

Gyuyoung Kim <gyuyoung.kim>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gyuyoung.kim, leandro, lucas.de.marchi, rakuco, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Blogspot with viewport support	none
Blogspot without viewport support	none
m.wikipedia.org with viewport support	none
m.wikipedia.org without viewport support	none

Gyuyoung Kim

Reported 2011-10-19 23:43:54 PDT

'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag. However, it sets wrong layout to some web sites which have viewport meta tag. Because, host PC doesn't support proper DPI value though viewport is using DPI value to compute layout values. This signal is for mobile device.

Attachments
Patch (1.88 KB, patch) 2011-10-19 23:47 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Patch (5.25 KB, patch) 2011-10-20 21:09 PDT, Gyuyoung Kim	no flags	Details Formatted Diff Diff
Blogspot with viewport support (37.87 KB, image/png) 2011-10-20 21:11 PDT, Gyuyoung Kim	no flags	Details
Blogspot without viewport support (76.23 KB, image/png) 2011-10-20 21:11 PDT, Gyuyoung Kim	no flags	Details
m.wikipedia.org with viewport support (104.98 KB, image/png) 2011-10-20 21:12 PDT, Gyuyoung Kim	no flags	Details
m.wikipedia.org without viewport support (142.75 KB, image/png) 2011-10-20 21:12 PDT, Gyuyoung Kim	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Gyuyoung Kim

Comment 1 2011-10-19 23:47:25 PDT

Created attachment 111730 [details] Patch

Raphael Kubo da Costa (:rakuco)

Comment 2 2011-10-20 05:47:41 PDT

Comment on attachment 111730 [details] Patch Can you explain in more details what the problem with the current code is? I couldn't understand it from the ChangeLog message. Plus, if you're really going to unregister the signal, you can also remove the whole on_viewport_changed function as well.

Gyuyoung Kim

Comment 3 2011-10-20 21:09:15 PDT

Created attachment 111893 [details] Patch

Gyuyoung Kim

Comment 4 2011-10-20 21:11:05 PDT

Created attachment 111894 [details] Blogspot with viewport support

Gyuyoung Kim

Comment 5 2011-10-20 21:11:39 PDT

Created attachment 111895 [details] Blogspot without viewport support

Gyuyoung Kim

Comment 6 2011-10-20 21:12:17 PDT

Created attachment 111896 [details] m.wikipedia.org with viewport support

Gyuyoung Kim

Comment 7 2011-10-20 21:12:48 PDT

Created attachment 111897 [details] m.wikipedia.org without viewport support

Gyuyoung Kim

Comment 8 2011-10-20 21:24:43 PDT

(In reply to comment #2) > (From update of attachment 111730 [details]) > Can you explain in more details what the problem with the current code is? I couldn't understand it from the ChangeLog message. I attach screenshots to let you understand this patch's goal. In blogspot case, blogspot has viewport meta tag as below, <meta content='width=1100' name='viewport'/> Then, EWebLauncher sets layout according to viewport computation logic with device dpi. However, viewport algorithm computes the DPI ratio based on 160(iphone 3Gs dpi). viewport callback of EWebLauncher sets zoom-in via the DPI ratio. So, EWebLauncher can't set proper layout because host PC usually has low DPI. Especially, it is difficult to test mobile sites on EWebLauncher because of this problem. For example, en.m.wikipedia.org > Plus, if you're really going to unregister the signal, you can also remove the whole on_viewport_changed function as well. Fixed.

Raphael Kubo da Costa (:rakuco)

Comment 9 2011-10-22 08:42:21 PDT

Alright, informal r+. Sorry for the delay, I wasn't in the bug's CC list.

Eric Seidel (no email)

Comment 10 2011-10-26 00:52:04 PDT

Comment on attachment 111893 [details] Patch rs=me.

WebKit Review Bot

Comment 11 2011-10-26 01:12:10 PDT

Comment on attachment 111893 [details] Patch Clearing flags on attachment: 111893 Committed r98444: <http://trac.webkit.org/changeset/98444>

WebKit Review Bot

Comment 12 2011-10-26 01:12:15 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.