Bug 70476

Summary: REGRESSION(r97881): It broke fast/dom/error-to-string-stack-overflow.html
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: arv, ossy, webkit.review.bot
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 70432    
Attachments:
Description Flags
Patch
none
Patch none

Csaba Osztrogonác
Reported 2011-10-19 23:37:52 PDT
--- /ramdisk/qt-linux-release/build/layout-test-results/fast/dom/error-to-string-stack-overflow-expected.txt +++ /ramdisk/qt-linux-release/build/layout-test-results/fast/dom/error-to-string-stack-overflow-actual.txt @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 15: RangeError: Maximum call stack size exceeded. +CONSOLE MESSAGE: line 14: RangeError: Maximum call stack size exceeded. Regression test for https://bugs.webkit.org/show_bug.cgi?id=30774. This test passes if it doesn't crash. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
Attachments
Patch (2.88 KB, patch)
2011-11-24 11:57 PST, Lauro Moura Maranhao Neto 		no flags
DetailsFormatted DiffDiff
Patch (2.96 KB, patch)
2011-11-24 12:11 PST, Lauro Moura Maranhao Neto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2011-10-19 23:47:25 PDT
Temporarily skipped by http://trac.webkit.org/changeset/97943
Erik Arvidsson
Comment 2 2011-10-20 08:36:01 PDT
This just needs to be rebaselined.
Csaba Osztrogonác
Comment 3 2011-10-20 08:40:35 PDT
(In reply to comment #2) > This just needs to be rebaselined. Thanks, will do.
Lauro Moura Maranhao Neto
Comment 4 2011-11-24 11:57:54 PST
Created attachment 116526 [details] Patch
Alexis Menard (darktears)
Comment 5 2011-11-24 12:02:51 PST
Comment on attachment 116526 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116526&action=review > LayoutTests/ChangeLog:7 > + You told me face to face that the base/generic expected file is good enough. Please tell it in the changelog here under Reviewed by (with one empty line in between) so that people can understand when reading the changelog.
Lauro Moura Maranhao Neto
Comment 6 2011-11-24 12:11:00 PST
Created attachment 116529 [details] Patch
Andreas Kling
Comment 7 2011-11-27 04:19:22 PST
Comment on attachment 116529 [details] Patch Coolio :)
WebKit Review Bot
Comment 8 2011-11-27 05:31:11 PST
Comment on attachment 116529 [details] Patch Clearing flags on attachment: 116529 Committed r101200: <http://trac.webkit.org/changeset/101200>
WebKit Review Bot
Comment 9 2011-11-27 05:31:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.