Bug 70474 – [Forms][File] Add tooltip to "No file selected" text

• Component: Forms
• Status: RESOLVED FIXED

When width of file input element isn't enough for displaying "No file selected" text is truncated. There is no way for users to see entire text.

Sample HTML:
<input type="file" style="border: solid 1px red; width: 150px">

Sample Rendering:
[Choose File] No f....sen

This change fixes following Chromium bug:
Message 'no file selected' is not completed in Czech and some other languages
http://crbug.com/23354

Created attachment 111733 [details]
Patch 1

[WebKit Review Bot]

Comment on attachment 111733 [details]
Patch 1

Attachment 111733 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10179350

[Gyuyoung Kim]

Comment on attachment 111733 [details]
Patch 1

Attachment 111733 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10178336

[Early Warning System Bot]

Comment on attachment 111733 [details]
Patch 1

Attachment 111733 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10180386

Created attachment 111735 [details]
Patch 2

[Kent Tamura]

Comment on attachment 111735 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=111735&action=review

> Source/WebCore/ChangeLog:5
> +        Changes for check-webkit-style

Do not include style changes.  They are unrelated to the bug.

Also, please write the reason why you change the behavior.

> Source/WebCore/ChangeLog:22
> +        * html/FileInputType.cpp:
> +        (WebCore::FileInputType::getToolTip):
> +        * html/FileInputType.h:
> +        * html/HTMLInputElement.cpp:
> +        (WebCore::HTMLInputElement::parseMappedAttribute):
> +        (WebCore::HTMLInputElement::getToolTip):
> +        * html/HTMLInputElement.h:
> +        * html/InputType.cpp:
> +        (WebCore::InputType::getToolTip):
> +        * html/InputType.h:
> +        * page/Chrome.cpp:
> +        (WebCore::Chrome::setToolTip):

Please write what you changed for each of files/functions as possible.

> Source/WebCore/html/FileInputType.h:68
> +    virtual String getToolTip() const;

Please append OVERRIDE.

> Source/WebCore/html/HTMLInputElement.cpp:54
> -#include "SearchInputType.h"
>  #include "ScriptEventListener.h"
> +#include "SearchInputType.h"

Do not change this in this patch.

> Source/WebCore/html/HTMLInputElement.cpp:800
> -        // FIXME: Detaching just for maxResults change is not ideal.  We should figure out the right
> +        // FIXME: Detaching just for maxResults change is not ideal. We should figure out the right

ditto.

> Source/WebCore/html/HTMLInputElement.h:59
> -    // Returns the minimum value for type=date, number, or range.  Don't call this for other types.
> +    // Returns the minimum value for type=date, number, or range. Don't call this for other types.
>      double minimum() const;
> -    // Returns the maximum value for type=date, number, or range.  Don't call this for other types.
> +    // Returns the maximum value for type=date, number, or range. Don't call this for other types.

ditto.

> Source/WebCore/html/HTMLInputElement.h:320
> -    
> +

ditto.

> Source/WebCore/html/HTMLInputElement.h:325
> -    // Helper for stepUp()/stepDown().  Adds step value * count to the current value.
> +    // Helper for stepUp()/stepDown(). Adds step value * count to the current value.

ditto.

> Source/WebCore/html/HTMLInputElement.h:357
> -} //namespace
> +} // namespace

ditto.

> Source/WebCore/html/InputType.h:36
> -#include <wtf/Forward.h>
>  #include <wtf/FastAllocBase.h>
> +#include <wtf/Forward.h>

ditto.

> Source/WebCore/html/InputType.h:77
> -    WTF_MAKE_NONCOPYABLE(InputType); WTF_MAKE_FAST_ALLOCATED;
> +    WTF_MAKE_NONCOPYABLE(InputType);
> +    WTF_MAKE_FAST_ALLOCATED;

ditto.

> Source/WebCore/page/Chrome.cpp:28
> -#include "FileIconLoader.h"
>  #include "FileChooser.h"
> +#include "FileIconLoader.h"

ditto.

> Source/WebCore/page/Chrome.cpp:424
> +                // TODO(yosin): We should obtain text direction of tooltip

TODO(name) is chromium-style. We should change it to FIXME: .

Created attachment 111739 [details]
Patch

[Kent Tamura]

Comment on attachment 111739 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111739&action=review

> Source/WebCore/ChangeLog:25
> +        * html/FileInputType.cpp:
> +        (WebCore::FileInputType::getToolTip):
> +        * html/FileInputType.h:
> +        * html/HTMLInputElement.cpp:
> +        (WebCore::HTMLInputElement::getToolTip):
> +        * html/HTMLInputElement.h:
> +        * html/InputType.cpp:
> +        (WebCore::InputType::getToolTip):
> +        * html/InputType.h:
> +        * page/Chrome.cpp:
> +        (WebCore::Chrome::setToolTip):

Please write what is changed for each of files/functions as possible.

> Source/WebCore/html/HTMLInputElement.h:236
> +    String getToolTip() const;
> +

Please see item 6 and 7 of 'Names' section of http://www.webkit.org/coding/coding-style.html.
This function should be toolTip()", not getToolTip().

Also, I think defaultToolTip() or fallbackToolTip() is better.

> Source/WebCore/html/InputType.h:241
> +    virtual String getToolTip() const;

ditto.

Created attachment 111743 [details]
Patch 4

[Kent Tamura]

Comment on attachment 111743 [details]
Patch 4

Looks good.

[WebKit Review Bot]

Comment on attachment 111743 [details]
Patch 4

Clearing flags on attachment: 111743

Committed r98054: <http://trac.webkit.org/changeset/98054>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.