Bug 70443

Summary: Removed StringImplBase, fusing it into StringImpl
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch barraclough: review+

Geoffrey Garen
Reported 2011-10-19 14:52:25 PDT
Removed StringImplBase, fusing it into StringImpl
Attachments
Patch (18.53 KB, patch)
2011-10-19 14:53 PDT, Geoffrey Garen 		barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-10-19 14:53:58 PDT
Created attachment 111679 [details] Patch
WebKit Review Bot
Comment 2 2011-10-19 15:37:38 PDT
Attachment 111679 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/text/StringImpl.h:66: More than one command on the same line [whitespace/newline] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Geoffrey Garen
Comment 3 2011-10-19 16:54:46 PDT
Committed r97894: <http://trac.webkit.org/changeset/97894>
Note You need to log in before you can comment on or make changes to this bug.