Bug 70437

Summary:

Wrong icon to restore to windowed mode in full screen video panel

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

Media

Assignee:

Jer Noble <jer.noble>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, gustavo, webkit.review.bot, xan.lopez

Priority:

P2

Keywords:

InRadar, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

URL:

http://www.808.dk/?code-html-5-video

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	eric.carlson: review+

Jer Noble

Reported 2011-10-19 13:45:01 PDT

Go to http://www.808.dk/?code-html-5-video Make the video full screen. The panel's button to return the video back to windowed mode shows the full screen icon, not the window icon.

Attachments
Patch (344.31 KB, patch) 2012-03-14 10:25 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (360.77 KB, patch) 2012-03-14 11:34 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (361.69 KB, patch) 2012-03-14 11:56 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (361.69 KB, patch) 2012-03-14 12:22 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (1.37 MB, patch) 2012-03-14 14:29 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (1.37 MB, patch) 2012-03-15 16:47 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (1.37 MB, patch) 2012-03-15 17:11 PDT, Jer Noble	eric.carlson: review+	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2011-10-19 13:45:21 PDT

<rdar://problem/9511161>

Jer Noble

Comment 2 2012-03-14 10:25:35 PDT

Created attachment 131878 [details] Patch

Build Bot

Comment 3 2012-03-14 10:46:49 PDT

Comment on attachment 131878 [details] Patch Attachment 131878 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11955136

Jer Noble

Comment 4 2012-03-14 11:34:14 PDT

Created attachment 131892 [details] Patch Fixed windows build; added localized string updates.

Build Bot

Comment 5 2012-03-14 11:44:12 PDT

Comment on attachment 131892 [details] Patch Attachment 131892 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11954217

Jer Noble

Comment 6 2012-03-14 11:56:56 PDT

Created attachment 131896 [details] Patch Further windows compilation fixes.

Build Bot

Comment 7 2012-03-14 12:17:46 PDT

Comment on attachment 131896 [details] Patch Attachment 131896 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11953321

Jer Noble

Comment 8 2012-03-14 12:22:18 PDT

Created attachment 131898 [details] Patch Sigh. I really need to get a local Windows 7 install.

Build Bot

Comment 9 2012-03-14 12:31:11 PDT

Comment on attachment 131898 [details] Patch Attachment 131898 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11951338

WebKit Review Bot

Comment 10 2012-03-14 12:33:21 PDT

Comment on attachment 131898 [details] Patch Attachment 131898 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11953330

Jer Noble

Comment 11 2012-03-14 14:29:15 PDT

Created attachment 131924 [details] Patch

Build Bot

Comment 12 2012-03-14 14:45:43 PDT

Comment on attachment 131924 [details] Patch Attachment 131924 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/11952386

Build Bot

Comment 13 2012-03-14 14:48:19 PDT

Comment on attachment 131924 [details] Patch Attachment 131924 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/11955232

Early Warning System Bot

Comment 14 2012-03-14 14:59:21 PDT

Comment on attachment 131924 [details] Patch Attachment 131924 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/11957214

Early Warning System Bot

Comment 15 2012-03-14 15:00:15 PDT

Comment on attachment 131924 [details] Patch Attachment 131924 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11951410

WebKit Review Bot

Comment 16 2012-03-14 15:14:47 PDT

Comment on attachment 131924 [details] Patch Attachment 131924 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/11951421

Early Warning System Bot

Comment 17 2012-03-14 15:58:39 PDT

Comment on attachment 131924 [details] Patch Attachment 131924 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/11957269

Gustavo Noronha (kov)

Comment 18 2012-03-14 16:59:19 PDT

Comment on attachment 131924 [details] Patch Attachment 131924 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11952480

Gyuyoung Kim

Comment 19 2012-03-14 19:05:31 PDT

Comment on attachment 131924 [details] Patch Attachment 131924 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/11952576

Jer Noble

Comment 20 2012-03-15 16:47:59 PDT

Created attachment 132147 [details] Patch Definitely building on mac and chromium-linux. Probably building on win.

Jer Noble

Comment 21 2012-03-15 17:11:10 PDT

Created attachment 132156 [details] Patch Rebased.

Jer Noble

Comment 22 2012-03-15 17:24:15 PDT

I have no idea why these patches aren't applying. I"m going to blame Localizable.strings. Please review it anyway. :)

Jer Noble

Comment 23 2012-03-16 12:22:03 PDT

Committed r111041: <http://trac.webkit.org/changeset/111041>

Note You need to log in before you can comment on or make changes to this bug.