Bug 70413

Summary: [Qt] Disable fullscreen api on Qt by default
Product: WebKit Reporter: Chang Shu <cshu>
Component: New BugsAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, noam, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch 1 none

Chang Shu
Reported 2011-10-19 07:05:50 PDT
As the WebKit side of implementation for fullscreen api feature has not been done yet, we'd better turn off the feature on the WebCore side by default.
Attachments
patch 1 (3.19 KB, patch)
2011-10-19 07:53 PDT, Chang Shu 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2011-10-19 07:53:51 PDT
Created attachment 111619 [details] patch 1
Chang Shu
Comment 2 2011-10-19 10:47:02 PDT
It turns out the WK2 support for this feature is trivial, at least from layout test point of view. We don't have to disable this feature. Please refer to bug 70111.
Chang Shu
Comment 3 2011-10-19 13:42:37 PDT
Even the current implementation in Qt WK2 is able to make most of the fullscreen api tests pass, the real stuff is still not there yet. So we still want to disable the feature.
Chang Shu
Comment 4 2011-10-19 14:06:40 PDT
Comment on attachment 111619 [details] patch 1 Clearing flags on attachment: 111619 Committed r97875: <http://trac.webkit.org/changeset/97875>
Chang Shu
Comment 5 2011-10-19 14:06:48 PDT
All reviewed patches have been landed. Closing bug.
Csaba Osztrogonác
Comment 6 2011-10-19 23:49:35 PDT
You forgot running layout tests before landing and watching bots after landing ... I had to update an expected result to make buildbot happy _instead of you_ guys: http://trac.webkit.org/changeset/97943/trunk/LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt
Chang Shu
Comment 7 2011-10-20 06:01:57 PDT
Sorry about the layout test failures. I left work before the buildbot finished building.
Note You need to log in before you can comment on or make changes to this bug.