Bug 70397 – Rename AllowAllocation to a better name

• Component: DOM
• Status: RESOLVED FIXED

[Kentaro Hara]

The name 'AllowAllocation' is confusing (See discussion here: bug 70015). We should rename it to clarify that this class is for distinguishing the following two situations:

1. A programmer allocates an object via "new X"; X is a function with a C++ constructCallback.
2. C++ allocates an object via the function template and tries to wrap the object with the JS flavor.

[Kentaro Hara]

Created attachment 111563 [details]
Patch

[Adam Barth]

Comment on attachment 111563 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111563&action=review

> Source/WebCore/bindings/v8/V8Binding.h:211
> -        AllowAllocation allow;
> +        ConstructorMode allow;

Maybe rename "allow" to something else?

[Kentaro Hara]

Created attachment 111568 [details]
patch for commit

[Kentaro Hara]

(In reply to comment #2)
> (From update of attachment 111563 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=111563&action=review
> 
> > Source/WebCore/bindings/v8/V8Binding.h:211
> > -        AllowAllocation allow;
> > +        ConstructorMode allow;
> 
> Maybe rename "allow" to something else?

Renamed to "constructorMode", and committed. Thanks.

By the way, I am planning to add the ConstructorMode check to all existing custom ~25 constructors, but does that make sense?

[WebKit Review Bot]

Comment on attachment 111568 [details]
patch for commit

Clearing flags on attachment: 111568

Committed r97839: <http://trac.webkit.org/changeset/97839>

[Adam Barth]

> By the way, I am planning to add the ConstructorMode check to all existing custom ~25 constructors, but does that make sense?

Yep.