Summary: | Rename AllowAllocation to a better name | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kentaro Hara <haraken> | ||||||
Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, dominicc, japhet, webkit.review.bot | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Kentaro Hara
2011-10-18 21:43:53 PDT
Created attachment 111563 [details]
Patch
Comment on attachment 111563 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111563&action=review > Source/WebCore/bindings/v8/V8Binding.h:211 > - AllowAllocation allow; > + ConstructorMode allow; Maybe rename "allow" to something else? Created attachment 111568 [details]
patch for commit
(In reply to comment #2) > (From update of attachment 111563 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=111563&action=review > > > Source/WebCore/bindings/v8/V8Binding.h:211 > > - AllowAllocation allow; > > + ConstructorMode allow; > > Maybe rename "allow" to something else? Renamed to "constructorMode", and committed. Thanks. By the way, I am planning to add the ConstructorMode check to all existing custom ~25 constructors, but does that make sense? Comment on attachment 111568 [details] patch for commit Clearing flags on attachment: 111568 Committed r97839: <http://trac.webkit.org/changeset/97839> > By the way, I am planning to add the ConstructorMode check to all existing custom ~25 constructors, but does that make sense?
Yep.
|