Bug 70365

Summary: Web Inspector: Some localizedStrings.js Updates
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web Inspector (Deprecated)Assignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Update localizedStrings.js and related tooling darin: review+

Description Joseph Pecoraro 2011-10-18 14:24:10 PDT
Currently inspecting the inspector shows the following error:

    ReferenceError: Left side of assignment is not a reference.

Referring to the following error JS error in localizedStrings.js:

    localizedStrings["Edit"] = "Edit";
    ["Elements Panel"] = "Elements Panel";
    localizedStrings["Elements"] = "Elements";

I also remember there was an awesome script, it needed an update but running check-inspector-strings I saw:

    shell> ./Tools/Scripts/check-inspector-strings 
    check-inspector-strings: [INFO] New: "Profile %d"
    check-inspector-strings: [INFO] New: "Automatically attach to new workers. Enabling this option will force opening inspector for all new workers."
    check-inspector-strings: [INFO] New: "Worker inspectors"
    check-inspector-strings: [INFO] New: "Stamp"
    check-inspector-strings: [INFO] New: "Enable worker inspection"
    check-inspector-strings: [INFO] New: "No Watch Expressions"
    check-inspector-strings: [INFO] New: "Start/stop recording"
    check-inspector-strings: [INFO] New: "Callback ID"
    check-inspector-strings: [INFO] New: "Timeline Panel"
    check-inspector-strings: [INFO] Suspicious: "Open Link in Resources Panel"
    check-inspector-strings: [INFO] Suspicious: "Edit Text"
    check-inspector-strings: [INFO] Suspicious: "Documents"
    check-inspector-strings: [INFO] Suspicious: "Continue to here"
    check-inspector-strings: [INFO] Suspicious: "Copy Image URL"
    check-inspector-strings: [INFO] Suspicious: "Delete Node"
    check-inspector-strings: [INFO] Suspicious: "Open link in new tab"
    check-inspector-strings: [INFO] Suspicious: "Break on subtree modifications"
    check-inspector-strings: [INFO] Suspicious: "Add attribute"
    check-inspector-strings: [INFO] Suspicious: "Add Breakpoint"
    check-inspector-strings: [INFO] Suspicious: "Break on attributes modifications"
    check-inspector-strings: [INFO] Suspicious: "Enable breakpoint"
    check-inspector-strings: [INFO] Suspicious: "Word Wrap"
    check-inspector-strings: [INFO] Suspicious: "Copy Entry as HAR"
    check-inspector-strings: [INFO] Suspicious: "Disable breakpoint"
    check-inspector-strings: [INFO] Suspicious: "Copy All as HAR"
    check-inspector-strings: [INFO] Suspicious: "Copy Link Address"
    check-inspector-strings: [INFO] Suspicious: "Edit text"
    check-inspector-strings: [INFO] Suspicious: "Copy image URL"
    check-inspector-strings: [INFO] Suspicious: "Paused on a \"%s\" breakpoint set on %s."
    check-inspector-strings: [INFO] Suspicious: "Continue to Here"
    check-inspector-strings: [INFO] Suspicious: "Paused on a \"%s\" breakpoint set on %s, because its descendant %s was removed."
    check-inspector-strings: [INFO] Suspicious: "Delete node"
    check-inspector-strings: [INFO] Suspicious: "Save all as HAR"
    check-inspector-strings: [INFO] Suspicious: "Add Attribute"
    check-inspector-strings: [INFO] Suspicious: "As Authored"
    check-inspector-strings: [INFO] Suspicious: "Copy Response Headers"
    check-inspector-strings: [INFO] Suspicious: "Stylesheets"
    check-inspector-strings: [INFO] Suspicious: "Add breakpoint"
    check-inspector-strings: [INFO] Suspicious: "Open in network panel"
    check-inspector-strings: [INFO] Suspicious: "Break on Node Removal"
    check-inspector-strings: [INFO] Suspicious: "Copy request headers"
    check-inspector-strings: [INFO] Suspicious: "Disable Breakpoint"
    check-inspector-strings: [INFO] Suspicious: "Add conditional breakpoint…"
    check-inspector-strings: [INFO] Suspicious: "Edit Attribute"
    check-inspector-strings: [INFO] Suspicious: "Open link in Resources panel"
    check-inspector-strings: [INFO] Suspicious: "Comparison"
    check-inspector-strings: [INFO] Suspicious: "Containment"
    check-inspector-strings: [INFO] Suspicious: "Remove breakpoint"
    check-inspector-strings: [INFO] Suspicious: "Edit Breakpoint…"
    check-inspector-strings: [INFO] Suspicious: "Paused on a \"%s\" breakpoint set on %s, because a new child was added to that node."
    check-inspector-strings: [INFO] Suspicious: "Open in Network Panel"
    check-inspector-strings: [INFO] Suspicious: "Fonts"
    check-inspector-strings: [INFO] Suspicious: "new"
    check-inspector-strings: [INFO] Suspicious: "Save As..."
    check-inspector-strings: [INFO] Suspicious: "Paused on a \"%s\" breakpoint set on %s, because a new child was added to its descendant %s."
    check-inspector-strings: [INFO] Suspicious: "Copy entry as HAR"
    check-inspector-strings: [INFO] Suspicious: "Dominators"
    check-inspector-strings: [INFO] Suspicious: "Enable Breakpoint"
    check-inspector-strings: [INFO] Suspicious: "Break on Subtree Modifications"
    check-inspector-strings: [INFO] Suspicious: "Save entry as HAR"
    check-inspector-strings: [INFO] Suspicious: "Open image in new tab"
    check-inspector-strings: [INFO] Suspicious: "Summary"
    check-inspector-strings: [INFO] Suspicious: "Copy response headers"
    check-inspector-strings: [INFO] Suspicious: "Save Entry as HAR"
    check-inspector-strings: [INFO] Suspicious: "WebSockets"
    check-inspector-strings: [INFO] Suspicious: "Copy link address"
    check-inspector-strings: [INFO] Suspicious: "Edit breakpoint…"
    check-inspector-strings: [INFO] Suspicious: "Copy all as HAR"
    check-inspector-strings: [INFO] Suspicious: "Open Link in New Tab"
    check-inspector-strings: [INFO] Suspicious: "Break on Attributes Modifications"
    check-inspector-strings: [INFO] Suspicious: "Clear console"
    check-inspector-strings: [INFO] Suspicious: "Save as..."
    check-inspector-strings: [INFO] Suspicious: "Add Conditional Breakpoint…"
    check-inspector-strings: [INFO] Suspicious: "Images"
    check-inspector-strings: [INFO] Suspicious: "Break on node removal"
    check-inspector-strings: [INFO] Suspicious: "Copy Request Headers"
    check-inspector-strings: [INFO] Suspicious: "Save All as HAR"
    check-inspector-strings: [INFO] Suspicious: "Open Image in New Tab"
    check-inspector-strings: [INFO] Unused: "(whitespace)"
    check-inspector-strings: [INFO] Unused: "line %d"
    check-inspector-strings: [INFO] Unused: "Timeline.loadFromFile: File \"%s\" is not readable"
    check-inspector-strings: [INFO] Unused: "Mark"
    check-inspector-strings: [INFO] Unused: "Clear browser cache."
    check-inspector-strings: [INFO] Unused: "Add"
    check-inspector-strings: [INFO] Unused: "%s >1000%%"
    check-inspector-strings: [INFO] Unused: "Compared to %s"
    check-inspector-strings: [INFO] Unused: "Clear Browser Cookies."
    check-inspector-strings: [INFO] Unused: "1 - %d"
    check-inspector-strings: [INFO] Unused: "Expected Content Length"
    check-inspector-strings: [INFO] Unused: "JSON"
    check-inspector-strings: [INFO] Unused: "Objects"
    check-inspector-strings: [INFO] Unused: "Timeline.loadFromFile: An error occurred reading the file \"%s\""
    check-inspector-strings: [INFO] Unused: "Count"
    check-inspector-strings: [INFO] Unused: "Ignore case"
    check-inspector-strings: [INFO] Unused: "Format script."
    check-inspector-strings: [INFO] Unused: "Clear browser cookies."
    check-inspector-strings: [INFO] Unused: "deleted"
    check-inspector-strings: [INFO] Unused: "± Count"
    check-inspector-strings: [INFO] Unused: "opefile %d"
    check-inspector-strings: [INFO] Unused: "Continue"
    check-inspector-strings: [INFO] Unused: "Registered at"
    check-inspector-strings: [INFO] Unused: "You could save bandwidth by having your web server compress this transfer with gzip or zlib."
    check-inspector-strings: [INFO] Unused: "(data url)"
    check-inspector-strings: [INFO] Unused: "Code"
    check-inspector-strings: [INFO] Unused: "Please wait…"
    check-inspector-strings: [INFO] Unused: "Clear Browser Cache."
    check-inspector-strings: [INFO] Unused: "Regular expression"
    check-inspector-strings: [INFO] Unused: "Timeline.loadFromFile: File \"%s\" not found."
    check-inspector-strings: [INFO] Unused: "(internal script)"
    check-inspector-strings: [INFO] Unused: "%s%.2f%%"
    check-inspector-strings: [INFO] Unused: "Cancel"
    check-inspector-strings: [INFO] Unused: "± Size"
    check-inspector-strings: [INFO] Duplicate: "Preserve Log upon Navigation"

I verified a number of the "New" items, so I fixed them and the "Duplicate" item. I haven't gone through all items.
Comment 1 Joseph Pecoraro 2011-10-18 14:33:17 PDT
Created attachment 111503 [details]
[PATCH] Update localizedStrings.js and related tooling

• Fixed localizedStrings.js
• Added missing strings, removed Duplicate string.
• Updated check-inspector-strings so it works again!
• Copy localizedStrings.js in `build-webkit --inspector-frontend`
Comment 2 Joseph Pecoraro 2011-10-18 15:48:53 PDT
Landed in r97798 <http://trac.webkit.org/changeset/97798>.