Bug 70333

Summary: [Qt][WK2]: Shouldn't send unhandled TouchCancel event to gesture recognizers
Product: WebKit Reporter: Dinu Jacob <dinu.jacob>
Component: WebKit QtAssignee: Dinu Jacob <dinu.jacob>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch hausmann: review+

Description Dinu Jacob 2011-10-18 09:37:52 PDT 
QtPanGestureRecognizer and QtPinchGestureRecognizer needs only TouchBegin, TouchUpdate and TouchEnd. Sending TouchCancel event that is not handled results in an ASSERT in the gesture recognizers.
Comment 1 Dinu Jacob 2011-10-18 09:38:56 PDT 
In QTouchWebPageProxy::doneWithTouchEvent, the gesture recognizers should be reset even if TouchCancel event is not handled.
Comment 2 Dinu Jacob 2011-10-18 09:42:04 PDT 
Created attachment 111455 [details]
patch
Comment 3 Simon Hausmann 2011-11-01 14:04:04 PDT 
Comment on attachment 111455 [details]
patch

Fair enough :)

How do you synthesize TouchCancel? As a result of window deactivation maybe?
Comment 4 Dinu Jacob 2011-11-02 05:48:12 PDT 
(In reply to comment #3)
> (From update of attachment 111455 [details])
> Fair enough :)
> 
> How do you synthesize TouchCancel? As a result of window deactivation maybe?

Yes, and according to W3C spec, also if there are more touch points on the touch surface than an allowed 'max'.
Comment 5 Dinu Jacob 2011-11-02 05:48:54 PDT 
Can you also commit the patch please?

Thanks, Dinu
Comment 6 Simon Hausmann 2011-11-02 05:56:24 PDT 
Committed r99054: <http://trac.webkit.org/changeset/99054>
Comment 7 Dinu Jacob 2011-11-02 05:57:03 PDT 
(In reply to comment #6)
> Committed r99054: <http://trac.webkit.org/changeset/99054>

Thanks Simon.