Bug 70320

Summary:

step=.5 should be considered valid in <input type="number" step=".5">

Product:

WebKit

Reporter:

Sachin Puranik <jcqt43>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Fix for Incorporating the change in spec as specified.	tkent: review-
Patch incorporating the review comments.	none

Sachin Puranik

Reported 2011-10-18 06:00:43 PDT

Incorporating the spec change as per W3C bug http://www.w3.org/Bugs/Public/show_bug.cgi?id=13689 As per this bug if a page contains input tag as below. <input type="number" step=".5"> the Double value ".5" for step should be considered as valid. This is added in the spec in the revision number http://html5.org/tools/web-apps-tracker?from=6634&to=6635

Attachments
Fix for Incorporating the change in spec as specified. (11.54 KB, patch) 2011-10-21 04:41 PDT, Sachin Puranik	tkent: review-	Details Formatted Diff Diff
Patch incorporating the review comments. (11.04 KB, patch) 2011-10-25 04:35 PDT, Sachin Puranik	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sachin Puranik

Comment 1 2011-10-21 04:41:40 PDT

Created attachment 111940 [details] Fix for Incorporating the change in spec as specified. Fix with Layout test modified attached.

Kent Tamura

Comment 2 2011-10-23 19:06:23 PDT

Comment on attachment 111940 [details] Fix for Incorporating the change in spec as specified. View in context: https://bugs.webkit.org/attachment.cgi?id=111940&action=review > LayoutTests/fast/forms/input-step-as-double.html:4 > +<link rel="stylesheet" href="../../fast/js/resources/js-test-style.css"> This line is not needed. It is inserted automatically by js-test-pre.js. > LayoutTests/fast/forms/input-step-as-double.html:9 > +<p id="description"></p> > +<div id="console"></div> These two elements are not needed. They are created automatically. > LayoutTests/fast/forms/input-step-as-double.html:10 > +<script src="script-tests/input-step-as-double.js"></script> Do not make a separated .js file. Please embed it into here. > LayoutTests/fast/forms/script-tests/input-valueasnumber-number.js:-34 > -shouldBeTrue('isNaN(valueAsNumberFor(".2"))'); We should have a test for valueAsNumberFor(".") instead.

Sachin Puranik

Comment 3 2011-10-25 04:35:13 PDT

Created attachment 112316 [details] Patch incorporating the review comments. All the review comments addressed.

Kent Tamura

Comment 4 2011-10-25 06:50:05 PDT

Comment on attachment 112316 [details] Patch incorporating the review comments. Looks good. Thank you.

WebKit Review Bot

Comment 5 2011-10-25 07:03:53 PDT

Comment on attachment 112316 [details] Patch incorporating the review comments. Clearing flags on attachment: 112316 Committed r98342: <http://trac.webkit.org/changeset/98342>

WebKit Review Bot

Comment 6 2011-10-25 07:03:59 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.