Bug 70280 – Scroll animator tracing

• Component: New Bugs
• Status: RESOLVED FIXED

[Scott Byer]

Scroll animator tracing

[Scott Byer]

Created attachment 111339 [details]
Patch

WebKit style question here; my inclination was to create TraceEvent.h at the platform level, renamed the one in the chromium dir to TraceEventChromium.h, and have TraceEvent.h either include TraceEventChromium.h or empty define the macro, so I could remove the platform conditionals from ScrollAnimatorNone.cpp. Good impulse, or is this more minimal patch better?

[WebKit Review Bot]

Attachment 111339 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Nat Duca]

Comment on attachment 111339 [details]
Patch

<3 (though darn, we really need to figure out how to avoid all the platform-chromium goop.

[James Robinson]

I wonder if other platforms are interested in this tracing stuff - I could imagine a dtrace backend or whatnot.

[Scott Byer]

That's why I was thinking of lifting up the header - to both get rid of the PLATFORM goop in the implementation file and to leave the path open to implement the define for other platforms. But, should that be part of this CL or another? I can go either way.

The tracing stuff really helps figure out what's going on in time critical sections of code, so I could see it becoming really useful if it were carefully added (that is, not too much noise).

[James Robinson]

Comment on attachment 111339 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111339&action=review

This is fine as-is, imo. R=me with one nit

> Source/WebCore/platform/ScrollAnimatorNone.cpp:583
> +
> +

nit: extra newline

[Scott Byer]

Created attachment 111491 [details]
Remove extra line

[WebKit Review Bot]

Comment on attachment 111491 [details]
Remove extra line

Clearing flags on attachment: 111491

Committed r97803: <http://trac.webkit.org/changeset/97803>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.