Bug 70218

Summary:

[Soup] ApplicationCache download fails when response is cached by network layer

Product:

WebKit

Reporter:

Donggwan Kim <donggwan.kim>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
first patch for this bug	ap: review-, ap: commit-queue-

Donggwan Kim

Reported 2011-10-16 23:51:25 PDT

Repro Step 1. Build WebKit with libsoup in which SOUP_CACHE is enabled. 2. connect to http://html5demos.com/offlineapp 3. If 304(Not modified) response is received when Application Cache request for html5demos.css or h5utils-offline.js, then downloads failed Cause For current implementation of ApplicationCacheGroup, if 304 response is received for resource that is not cached by ApplicationCacheGroup, then downloads failed. If ApplicationCacheGroup requests resource when it downloads complete by SubResourceLoader and is cached by libsoup, then could get 304 response. In case of this, downloads failed.

Attachments
first patch for this bug (2.66 KB, patch) 2011-10-16 23:54 PDT, Donggwan Kim	ap: review- ap: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Donggwan Kim

Comment 1 2011-10-16 23:54:52 PDT

Created attachment 111219 [details] first patch for this bug

Alexey Proskuryakov

Comment 2 2011-10-17 11:46:50 PDT

Comment on attachment 111219 [details] first patch for this bug Some comments: 1. Fixes should have regression tests. 2. WebCore assumes that network layer doesn't pass 304 if it has the data. Soup should just transform the response as if it was not cached. 3. The proposed code doesn't work correctly anyway, as the response cached by Soup won't be saved in application cache.

Donggwan Kim

Comment 3 2011-10-20 00:13:38 PDT

Fixed by libsoup

Note You need to log in before you can comment on or make changes to this bug.