Bug 70090

Summary: [EFL] Remove const modifier from ctx_menu functions
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, lucas.de.marchi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch
none
updated patch none

Grzegorz Czajkowski
Reported 2011-10-13 23:00:46 PDT
Functions ewk_context_menu_show and ewk_context_menu_custom_get have got const modifer to ensure that Ewk_Context_Menu won't be changed. The methods emit events through evas_object_smart_callback_call with Ewk_Context_Menu as parameter which is converted to void *. In this case an application which receives those events may change Ewk_Context_Menu. Additionaly the name of ewk_context_menu_custom_get has been changed to ewk_context_menu_customize because an application is able to modify the items of context menu.
Attachments
proposed patch (2.92 KB, patch)
2011-10-13 23:02 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
updated patch (2.99 KB, patch)
2011-10-14 03:22 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2011-10-13 23:02:46 PDT
Created attachment 110963 [details] proposed patch
Gyuyoung Kim
Comment 2 2011-10-14 02:42:55 PDT
Comment on attachment 110963 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=110963&action=review This patch needs to rebase. > Source/WebKit/efl/ewk/ewk_contextmenu.cpp:304 > +Ewk_Context_Menu* ewk_context_menu_customize(Ewk_Context_Menu* o) o was changed by menu. > Source/WebKit/efl/ewk/ewk_contextmenu.cpp:319 > +void ewk_context_menu_show(Ewk_Context_Menu* o) ditto.
Grzegorz Czajkowski
Comment 3 2011-10-14 03:22:36 PDT
Created attachment 110989 [details] updated patch
Grzegorz Czajkowski
Comment 4 2011-10-14 03:30:30 PDT
(In reply to comment #2) > (From update of attachment 110963 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110963&action=review > > This patch needs to rebase. > > > Source/WebKit/efl/ewk/ewk_contextmenu.cpp:304 > > +Ewk_Context_Menu* ewk_context_menu_customize(Ewk_Context_Menu* o) > > o was changed by menu. > > > Source/WebKit/efl/ewk/ewk_contextmenu.cpp:319 > > +void ewk_context_menu_show(Ewk_Context_Menu* o) > > ditto. Yes, you're right. Thanks.
Raphael Kubo da Costa (:rakuco)
Comment 5 2011-10-14 04:42:45 PDT
Comment on attachment 110989 [details] updated patch Informal r+.
Gyuyoung Kim
Comment 6 2011-10-14 04:48:49 PDT
Comment on attachment 110989 [details] updated patch LGTM.
WebKit Review Bot
Comment 7 2011-10-18 07:15:23 PDT
Comment on attachment 110989 [details] updated patch Clearing flags on attachment: 110989 Committed r97749: <http://trac.webkit.org/changeset/97749>
WebKit Review Bot
Comment 8 2011-10-18 07:15:27 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.