Bug 70074

Summary: Redundant comparison in AccessibilityObject.cpp updateAXLineStartForVisiblePosition
Product: WebKit Reporter: Ryan Sleevi <rsleevi>
Component: AccessibilityAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, cfleizach, morrita, rniwa, thakis
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
cleanup none

Ryan Sleevi
Reported 2011-10-13 16:41:58 PDT
This was reported upstream to Chromium by way of PVS Studio ( http://www.viva64.com/en/b/0113/ ), Fragment N11 http://trac.webkit.org/browser/trunk/Source/WebCore/accessibility/AccessibilityObject.cpp?annotate=blame&rev=96973#L481 Line 487: while (true) { tempPosition = startPosition.previous(); if (tempPosition.isNull() || tempPosition.isNull()) break; Position p = tempPosition.deepEquivalent(); The bug is that the conditional checks if tempPosition.isNull() twice. It's not clear what is meant to be checked here - startPosition.isNull() ? It was introduced in http://trac.webkit.org/changeset/92451
Attachments
cleanup (1.37 KB, patch)
2011-10-14 09:35 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-10-13 18:04:11 PDT
Ok, this is definitely a typo. The second isNull check is redundant and can be removed.
Ryosuke Niwa
Comment 2 2011-10-14 09:35:15 PDT
Created attachment 111023 [details] cleanup
chris fleizach
Comment 3 2011-10-14 09:52:34 PDT
Comment on attachment 111023 [details] cleanup r=me
Ryosuke Niwa
Comment 4 2011-10-14 10:56:48 PDT
Comment on attachment 111023 [details] cleanup Clearing flags on attachment: 111023 Committed r97479: <http://trac.webkit.org/changeset/97479>
Ryosuke Niwa
Comment 5 2011-10-14 10:56:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.