Summary: | Chromium: The NPObjectWrapper class used by V8 bindings to wrap the window object is not allocated correctly. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ananta Iyengar <ananta> | ||||||||
Component: | WebKit Misc. | Assignee: | Ananta Iyengar <ananta> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | inferno, japhet, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Ananta Iyengar
2011-10-13 15:20:00 PDT
Created attachment 110923 [details]
proposed patch
Comment on attachment 110923 [details] proposed patch Rejecting attachment 110923 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ]" exit_code: 1 Parsed 3 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/v8/NPObjectWrapper.cpp Hunk #1 FAILED at 84. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/v8/NPObjectWrapper.cpp.rej patching file Source/WebCore/bindings/v8/NPObjectWrapper.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Nate Chapin', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10052372 Created attachment 110934 [details] Patch with line endings fixed. This patch was already reviewed by Nate Chapin (japhet@chromium.org). It failed to apply probably due to inconsistent line endings. That has been fixed. Created attachment 110941 [details]
Patch
Comment on attachment 110941 [details]
Patch
Ok. Forwarding Nate's R+. Thanks for cleaning up the style and line endings.
Comment on attachment 110941 [details] Patch Rejecting attachment 110941 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Hunk #2 FAILED at 53. Hunk #3 FAILED at 138. Hunk #4 FAILED at 159. 4 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/bindings/v8/NPObjectWrapper.cpp.rej patching file Source/WebCore/bindings/v8/NPObjectWrapper.h Hunk #1 FAILED at 1. Hunk #2 FAILED at 71. 2 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/bindings/v8/NPObjectWrapper.h.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10052386 Committed r97429: <http://trac.webkit.org/changeset/97429> |